Skip to content

[WIP] Remove fake IDs in rustdoc - #75355

Closed
jyn514 wants to merge 2 commits into
rust-lang:masterfrom
jyn514:counterfeit
Closed

[WIP] Remove fake IDs in rustdoc#75355
jyn514 wants to merge 2 commits into
rust-lang:masterfrom
jyn514:counterfeit

Conversation

@jyn514

@jyn514jyn514 commented Aug 10, 2020

Copy link
Copy Markdown
Member

They're confusing and cause crashes. Part of an ongoing effort to debug #75176.

Not sure why the tests are failing, probably I'm not understanding why fake IDs were added in the first place.

@jyn514
Remove fake IDs in rustdoc
9cfe1a5
They're confusing, cause crashes, and aren't necessary.
@jyn514jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 10, 2020
@rust-highfive

rust-highfive commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

Some changes occurred in intra-doc-links.

cc @jyn514

@rust-highfive

rust-highfive commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2020
@jyn514
Don't ignore impls that have already been seen
758829e
This code path was never taken before because all the ids were fake. So
the ids would never have been seen before.
@Aaron1011

Aaron1011 commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

@jyn514: Fake DefIds exist to handle 'synthetic' auto trait impls, which don't have a real DefId.

@jyn514

jyn514 commented Aug 10, 2020

Copy link
Copy Markdown
MemberAuthor

@Aaron1011 do you know what the param_env_def_id represents, then? It's what get_auto_trait_impls is using to look up the synthetic impl.

@Aaron1011

Aaron1011 commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

@jyn514: param_env_def_id represents the item we are creating a synthetic impl for, and used to obtain the corresponding ParamEnv.

@bors

bors commented Aug 15, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #75549) made this pull request unmergeable. Please resolve the merge conflicts.

@jyn514jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2020
@jyn514jyn514 mentioned this pull request Sep 5, 2020
Open
@jyn514

jyn514 commented Sep 5, 2020

Copy link
Copy Markdown
MemberAuthor

Closing this because I think it needs more design work in rustdoc (#76382), the current approach isn't going to work.

@jyn514jyn514 closed this Sep 5, 2020
@jyn514jyn514 mentioned this pull request Dec 16, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2020
@bors
Auto merge ofrust-lang#80090- jyn514:tcx-in-render, r=GuillaumeGomez
d8d3ab9
Pass a `TyCtxt` through to `FormatRender`
This is the next step after rust-lang#79957 for rust-lang#76382. Eventually I plan to use this to remove `stability`, `const_stability`, and `deprecation` from `Item`, but that needs more extensive changes (in particular, rust-lang#75355 or something like it).
This has no actual changes to behavior, it's just moving types around.
ccc rust-lang#80014 (comment)
@jyn514
jyn514 deleted the counterfeit branch December 29, 2020 04:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jyn514@rust-highfive@Aaron1011@bors@GuillaumeGomez