Uh oh!
There was an error while loading. Please reload this page.
Fully handle "?" shortcut - #75393
Merged
Merged
Conversation
rust-highfive
commented
Aug 11, 2020
Contributor
Some changes occurred in HTML/CSS/JS. |
rust-highfive
commented
Aug 11, 2020
Contributor
r? @ollie27 (rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Aug 11, 2020
MemberAuthor
r? @jyn514 |
GuillaumeGomezforce-pushed
the
fix-help-shortcut
branch
2 times, most recently
from
August 11, 2020 11:54
e1d2090 to
81bb314CompareContributor
There was a problem hiding this comment.
Why not just remove this branch?
MemberAuthor
There was a problem hiding this comment.
I've been switching between this and removing the condition for a while. You made the balance change haha.
GuillaumeGomezforce-pushed
the
fix-help-shortcut
branch
from
August 11, 2020 16:28
81bb314 to
fdf2fe1Comparepickfire
approved these changes
Aug 11, 2020
pickfire
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me but I didn't test it out.
GuillaumeGomez
commented
Aug 11, 2020
MemberAuthor
I tested both and they worked on my computer. If an issue occurs, it's pretty simple to rollback. @bors: r=pickfire rollup |
bors
commented
Aug 11, 2020
Collaborator
📌 Commit fdf2fe1 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#75036 (Prefer pattern matching over indexing) - rust-lang#75378 (Introduce `rustc_lexer::is_ident` and use it in couple of places) - rust-lang#75393 (Fully handle "?" shortcut) - rust-lang#75403 (Update comment for function) - rust-lang#75407 (Requested changes to [*mut T|*const T]::set_ptr_value) - rust-lang#75408 (Update MinGW comments in ci.yml) - rust-lang#75409 (Fix range term in alloc vec doc) Failed merges: r? @ghost
jyn514
commented
Aug 11, 2020
Member
Looks like everyone took care of this without me 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#75386.
cc @runiq