Add help note when using type in place of const by JulianKnodt · Pull Request #75611 · rust-lang/rust

JulianKnodt · 2020-08-16T23:54:41Z

This adds a small help note when it might be possible that wrapping a parameter in braces might resolve the issue of having a type where a const was expected.

Currently, I am displaying the HirId, and I'm not particularly sure where to get the currently displayed path(?).

r? @lcnr

lcnr · 2020-08-21T08:52:34Z

awesome ✨
will try and review the actual code changes next week.

bors · 2020-08-22T02:58:56Z

☔ The latest upstream changes (presumably #75797) made this pull request unmergeable. Please resolve the merge conflicts.

rust-log-analyzer · 2020-08-22T03:30:03Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Initialized empty Git repository in /home/runner/work/rust/rust/.git/
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/75611/merge:refs/remotes/pull/75611/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-08-30T17:59:34Z

☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts.

Nice.

lcnr · 2020-09-11T06:40:16Z

@bors r+

bors · 2020-09-11T06:40:18Z

📌 Commit 96bb2c8 has been approved by lcnr

bors · 2020-09-11T08:40:12Z

⌛ Testing commit 96bb2c8 with merge a742547...

bors · 2020-09-11T10:44:44Z

☀️ Test successful - checks-actions, checks-azure
Approved by: lcnr
Pushing a742547 to master...

improve type const mismatch errors Doesn't completely remove `check_generic_arg_count` as that would have required some more complex changes but instead checks type and const params in only one step. Also moved the help added by `@JulianKnodt` in rust-lang#75611 to `generic_arg_mismatch_err`. r? `@varkor` cc `@petrochenkov`

rust-highfive assigned lcnr Aug 16, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2020

JulianKnodt force-pushed the cg_enum_err branch 2 times, most recently from 1ea9ffc to b3481d0Compare August 17, 2020 00:35

lcnr reviewed Aug 19, 2020
View reviewed changes

Comment threadsrc/librustc_typeck/astconv.rs Outdated

JulianKnodt marked this pull request as ready for review August 20, 2020 02:45

lcnr reviewed Aug 20, 2020
View reviewed changes

Comment threadsrc/librustc_typeck/astconv.rs Outdated

lcnr reviewed Aug 20, 2020
View reviewed changes

Comment threadsrc/librustc_typeck/astconv.rs Outdated

JulianKnodt force-pushed the cg_enum_err branch from 90071ef to 8d32a26Compare August 20, 2020 23:03

lcnr reviewed Aug 21, 2020
View reviewed changes

Comment threadsrc/librustc_typeck/astconv.rs Outdated
Comment threadsrc/librustc_typeck/astconv.rs Outdated

lcnr reviewed Aug 21, 2020
View reviewed changes

Comment threadsrc/librustc_typeck/astconv.rs Outdated

JulianKnodt force-pushed the cg_enum_err branch from f232056 to c70d1f7Compare August 21, 2020 07:55

lcnr reviewed Aug 21, 2020
View reviewed changes

JulianKnodt force-pushed the cg_enum_err branch from c70d1f7 to bdcbadbCompare August 22, 2020 03:26

JulianKnodt force-pushed the cg_enum_err branch 5 times, most recently from b11589d to 4a21039Compare August 22, 2020 06:00

JulianKnodt force-pushed the cg_enum_err branch from 4a21039 to 698ef42Compare August 30, 2020 19:29

lcnr reviewed Aug 31, 2020
View reviewed changes

Comment threadcompiler/rustc_typeck/src/astconv/generics.rs Outdated
Comment threadcompiler/rustc_typeck/src/astconv/generics.rs Outdated
Comment threadcompiler/rustc_typeck/src/astconv/generics.rs Outdated

JulianKnodt force-pushed the cg_enum_err branch 2 times, most recently from 6abde86 to 714c59bCompare September 1, 2020 21:00

lcnr reviewed Sep 3, 2020
View reviewed changes

Comment threadcompiler/rustc_typeck/src/astconv/generics.rs Outdated

JulianKnodt added 3 commits September 3, 2020 16:02

Initial commit
4b132ee

Update to use multipart suggestion
8d91875
Nice.

Add further tests and liberalize type checking
96bb2c8

JulianKnodt force-pushed the cg_enum_err branch from 714c59b to 96bb2c8Compare September 3, 2020 17:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2020

bors merged commit a742547 into rust-lang:masterSep 11, 2020

rustbot added this to the 1.48.0 milestone Sep 11, 2020

bors mentioned this pull request Sep 11, 2020
Add fix to error msg which relied on order #75444
Closed

lcnr mentioned this pull request Nov 13, 2020
improve type const mismatch errors #79032
Merged

Uh oh!

Uh oh!

Conversation

JulianKnodt commented Aug 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lcnrAug 21, 2020

Choose a reason for hiding this comment

Uh oh!

bors commented Aug 22, 2020

Uh oh!

rust-log-analyzer commented Aug 22, 2020

Uh oh!

bors commented Aug 30, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lcnr commented Sep 11, 2020

Uh oh!

bors commented Sep 11, 2020

Uh oh!

bors commented Sep 11, 2020

Uh oh!

bors commented Sep 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants