Uh oh!
There was an error while loading. Please reload this page.
Split up files with // ignore-tidy-filelength - #75701
Conversation
rust-highfive
commented
Aug 19, 2020
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
JohnTitor
left a comment
There was a problem hiding this comment.
Please format the changes with ./x.py fmt, at least.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
// ignore-tidy-filelengthUh oh!
There was an error while loading. Please reload this page.
petrochenkov
commented
Aug 19, 2020
@alex-griffiths If you'd like to do something in this direction, I'd suggest to start with moving |
alex-griffiths
commented
Aug 19, 2020
I'm so sorry. I didn't properly check that the changes I made at least built. I'll fix that now. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
petrochenkov
commented
Aug 19, 2020
@alex-griffiths |
bors
commented
Aug 24, 2020
☔ The latest upstream changes (presumably #75815) made this pull request unmergeable. Please resolve the merge conflicts. |
KodrAus
commented
Sep 4, 2020
Thanks for working on this @alex-griffiths! It looks like we've got some merge conflicts and a few broken doc links after the move: |
| #[stable(feature = "rust1", since = "1.0.0")] | ||
| pub mod utf8; | ||
| #[stable(feature = "rust1", since = "1.0.0")] | ||
| pub mod indices; |
There was a problem hiding this comment.
You don't need to public these mods.
JohnCSimon
commented
Sep 29, 2020
Ping from triage: |
Dylan-DPC-zz
commented
Sep 29, 2020
hi @alex-griffiths thanks for taking the time to contribute. This has been inactive for a while, so I have to close it. If you wish and have the time in future you can open a new PR and we'll take it forward from there :) Thanks |
Sorry it's taken me so long to get my act togethern on this, and that even with all the time, not much has been done. Hopefully what I've got here is at least acceptable.
One thing. When I'd build the compiler, I'd get some warnings about missing stability attributes. I wasn't sure the best way to fix this warning, so I've copied and pasted the stability attributes from the structs themselves. I hope this is okay. If not, I can try and fix it.
This is for #60302