Skip to content

Switch to intra-doc links in core::result - #75727

Merged
bors merged 3 commits into
rust-lang:masterfrom
camelid:intra-doc-links-for-core-result
Aug 21, 2020
Merged

Switch to intra-doc links in core::result#75727
bors merged 3 commits into
rust-lang:masterfrom
camelid:intra-doc-links-for-core-result

Conversation

@camelid

@camelidcamelid commented Aug 20, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Part of #75080.

@rustbot modify labels: A-intra-doc-links T-doc T-rustdoc

@rust-highfive

rust-highfive commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@rustbotrustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 20, 2020
camelid
camelid commented Aug 20, 2020
View reviewed changes
Comment threadlibrary/core/src/result.rs
@camelid
Revert to old link since intra-doc link is broken
22c02bf
Can't link from `core` to `std` yet.
camelid
camelid commented Aug 20, 2020
View reviewed changes
Comment threadlibrary/core/src/result.rs Outdated
@jyn514

jyn514 commented Aug 20, 2020

Copy link
Copy Markdown
Member

r? @jyn514

@rust-highfiverust-highfive assigned jyn514 and unassigned cramertjAug 20, 2020
jyn514
jyn514 reviewed Aug 20, 2020
View reviewed changes
Comment threadlibrary/core/src/result.rs Outdated
@camelidJoshua Nelson
Fix intra-doc links
5a307cf
One of the original links was linking to the wrong thing as well.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
@jyn514

jyn514 commented Aug 21, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 21, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5a307cf has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2020
@JohnTitorJohnTitor mentioned this pull request Aug 21, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2020
@bors
Auto merge ofrust-lang#75765- JohnTitor:rollup-lexaoa9, r=JohnTitor
32cb8d4
Rollup of 5 pull requests
Successful merges:
- rust-lang#75324 (clarify documentation of remove_dir errors)
- rust-lang#75532 (Fix RFC-1014 test)
- rust-lang#75664 (Update mailmap for mati865)
- rust-lang#75727 (Switch to intra-doc links in `core::result`)
- rust-lang#75750 (Move to intra doc links for std::thread documentation)
Failed merges:
r? @ghost
@bors
bors merged commit cccb889 into rust-lang:masterAug 21, 2020
@jyn514jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@cuvipercuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jyn514jyn514

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

7 participants

@camelid@rust-highfive@jyn514@bors@cuviper@cramertj@rustbot