Skip to content

Profiler: reenable atomics after #65214 - #75838

Merged
bors merged 1 commit into
rust-lang:masterfrom
mati865:profiler-atomics
Aug 25, 2020
Merged

Profiler: reenable atomics after #65214#75838
bors merged 1 commit into
rust-lang:masterfrom
mati865:profiler-atomics

Conversation

@mati865

@mati865mati865 commented Aug 23, 2020•
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented Aug 23, 2020

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2020
@mati865

mati865 commented Aug 24, 2020

Copy link
Copy Markdown
MemberAuthor

r? @Amanieu

@Amanieu

Amanieu commented Aug 24, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 24, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1a9def1 has been approved by Amanieu

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2020
@bors

bors commented Aug 24, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1a9def1 with merge ee2967c88c22164875057a790db83ba5daf4deb2...

@bors

bors commented Aug 24, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 24, 2020
@mati865

mati865 commented Aug 24, 2020

Copy link
Copy Markdown
MemberAuthor

Seems spurious:

-- Installing: /Users/runner/work/1/s/build/x86_64-apple-darwin/llvm/include/llvm/ADT/BreadthFirstIterator.h
Assertion failed: (timeout != -1), function uv__io_poll, file ../deps/uv/src/unix/kqueue.c, line 231.

@Amanieu

Amanieu commented Aug 24, 2020

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2020
@bors

bors commented Aug 25, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1a9def1 with merge 5890563...

@bors

bors commented Aug 25, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu
Pushing 5890563 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2020
@bors
bors merged commit 5890563 into rust-lang:masterAug 25, 2020
@mati865
mati865 deleted the profiler-atomics branch August 25, 2020 14:11
@cuvipercuviper added this to the 1.47.0 milestone Nov 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AmanieuAmanieu

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mati865@rust-highfive@Amanieu@bors@cuviper@nikomatsakis