Add check for doc alias on assoc const in trait impl by GuillaumeGomez · Pull Request #75888 · rust-lang/rust

GuillaumeGomez · 2020-08-24T18:21:24Z

GuillaumeGomez · 2020-08-30T16:41:42Z

bors · 2020-08-30T18:03:11Z

☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2020-08-31T19:37:30Z

Simplified the test (removed all non-compiling code too).

GuillaumeGomez · 2020-09-01T08:31:17Z

Removed the special case as well.

GuillaumeGomez · 2020-09-03T15:58:37Z

@ollie27 All comments have been resolved. Anything else? :)

ollie27 · 2020-09-03T20:06:26Z

Thanks.

@bors r+

bors · 2020-09-03T20:06:28Z

📌 Commit 2d88755cdd46bc1ce5c8f8b09d074f49b1e99e43 has been approved by ollie27

ollie27 · 2020-09-03T20:07:15Z

@bors r-

actually r=me when the commits have been squashed.

GuillaumeGomez · 2020-09-03T20:32:24Z

Squashed!

@bors: r=ollie27

bors · 2020-09-03T20:32:25Z

📌 Commit b61eab5 has been approved by ollie27

bors · 2020-09-04T09:17:55Z

⌛ Testing commit b61eab5 with merge 633762bf7474a946040507a8dddbd5c9b7c65c3a...

rust-log-analyzer · 2020-09-04T09:23:33Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

GuillaumeGomez · 2020-09-04T09:24:54Z

Spurious failure...

@bors: retry

bors · 2020-09-04T10:30:45Z

⌛ Testing commit b61eab5 with merge 21e91bea9278c68e503d78d057d8417a09342f49...

rust-log-analyzer · 2020-09-04T10:34:46Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

GuillaumeGomez · 2020-09-04T11:39:01Z

And another spurious failure. Is it normal @rust-lang/infra ?

@bors: retry

bors · 2020-09-04T11:39:13Z

⌛ Testing commit b61eab5 with merge 7f9c16191ae06ed7140d884345d3ba4c0ce913a2...

rust-log-analyzer · 2020-09-04T11:43:29Z

The job x86_64-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-09-04T11:44:45Z

💔 Test failed - checks-actions

GuillaumeGomez · 2020-09-04T15:13:54Z

Maybe it's fixed now...

@bors: retry

@ollie27

…st-doc-alias, r=ollie27 Add check for doc alias on assoc const in trait impl Fixesrust-lang#73721. r? @ollie27

@ollie27

…st-doc-alias, r=ollie27 Add check for doc alias on assoc const in trait impl Fixesrust-lang#73721. r? @ollie27

bors · 2020-09-05T09:35:23Z

⌛ Testing commit b61eab5 with merge 02fe309...

bors · 2020-09-05T11:46:54Z

☀️ Test successful - checks-actions, checks-azure
Approved by: ollie27
Pushing 02fe309 to master...

rust-highfive assigned ollie27 Aug 24, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2020

GuillaumeGomez changed the title ~~Trait impl assoc const doc alias~~Add check for doc alias on assoc const in trait implAug 24, 2020

tesuji reviewed Aug 25, 2020
View reviewed changes

Comment threadsrc/librustc_passes/check_attr.rs Outdated

ollie27 reviewed Aug 25, 2020
View reviewed changes

Comment threadsrc/test/rustdoc-ui/doc-alias-assoc-const.rs Outdated

jyn514 reviewed Aug 31, 2020
View reviewed changes

Comment threadsrc/test/rustdoc-ui/doc-alias-assoc-const.rs Outdated

jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 31, 2020

GuillaumeGomez force-pushed the trait-impl-assoc-const-doc-alias branch from dafc238 to dfb5b17Compare August 31, 2020 19:37

ollie27 reviewed Aug 31, 2020
View reviewed changes

Comment threadcompiler/rustc_passes/src/check_attr.rs Outdated

GuillaumeGomez force-pushed the trait-impl-assoc-const-doc-alias branch from 825b730 to 2d88755Compare September 1, 2020 08:40

ollie27 mentioned this pull request Sep 3, 2020
Tracking issue for #[doc(alias = "...")] #50146
Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 3, 2020

GuillaumeGomez added 2 commits September 3, 2020 22:11

Add check for doc alias on associated const in trait impls
6e43ff5

Add test for doc alias on associated const in trait impls
b61eab5

GuillaumeGomez force-pushed the trait-impl-assoc-const-doc-alias branch from 2d88755 to b61eab5Compare September 3, 2020 20:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2020

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 4, 2020
Rollup merge ofrust-lang#75888- GuillaumeGomez:trait-impl-assoc-con…
094ef1a
…st-doc-alias, r=ollie27 Add check for doc alias on assoc const in trait impl Fixesrust-lang#73721. r? @ollie27

Dylan-DPC-zz mentioned this pull request Sep 4, 2020
Rollup of 14 pull requests #76348
Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 4, 2020
Rollup merge ofrust-lang#75888- GuillaumeGomez:trait-impl-assoc-con…
6920100
…st-doc-alias, r=ollie27 Add check for doc alias on assoc const in trait impl Fixesrust-lang#73721. r? @ollie27

Dylan-DPC-zz mentioned this pull request Sep 4, 2020
Rollup of 13 pull requests #76350
Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 5, 2020

bors merged commit 02fe309 into rust-lang:masterSep 5, 2020

rustbot added this to the 1.48.0 milestone Sep 5, 2020

GuillaumeGomez deleted the trait-impl-assoc-const-doc-alias branch September 5, 2020 11:58

jyn514 added the A-doc-alias Area: `#[doc(alias)]` label Sep 27, 2020

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Aug 24, 2020

Uh oh!

Uh oh!

Uh oh!

GuillaumeGomez commented Aug 30, 2020

Uh oh!

bors commented Aug 30, 2020

Uh oh!

Uh oh!

GuillaumeGomez commented Aug 31, 2020

Uh oh!

Uh oh!

GuillaumeGomez commented Sep 1, 2020

Uh oh!

GuillaumeGomez commented Sep 3, 2020

Uh oh!

ollie27 commented Sep 3, 2020

Uh oh!

bors commented Sep 3, 2020

Uh oh!

ollie27 commented Sep 3, 2020

Uh oh!

GuillaumeGomez commented Sep 3, 2020

Uh oh!

bors commented Sep 3, 2020

Uh oh!

bors commented Sep 4, 2020

Uh oh!

rust-log-analyzer commented Sep 4, 2020

Uh oh!

GuillaumeGomez commented Sep 4, 2020

Uh oh!

bors commented Sep 4, 2020

Uh oh!

rust-log-analyzer commented Sep 4, 2020

Uh oh!

GuillaumeGomez commented Sep 4, 2020

Uh oh!

bors commented Sep 4, 2020

Uh oh!

rust-log-analyzer commented Sep 4, 2020

Uh oh!

bors commented Sep 4, 2020

Uh oh!

GuillaumeGomez commented Sep 4, 2020

Uh oh!

bors commented Sep 5, 2020

Uh oh!

bors commented Sep 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants