Skip to content

Improve theme button hover background color - #75901

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:ayu-theme-button-hover-background-color
Aug 30, 2020
Merged

Improve theme button hover background color#75901
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:ayu-theme-button-hover-background-color

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

@pickfirepickfire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better but still not so visible.

@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

Surprisingly it's quite visible when you're hovering and all. I prefer not to change the color too much for now though. Might be interesting to make another pass later on.

@bors: r=pickfire rollup

@bors

bors commented Aug 25, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f20f7f2 has been approved by pickfire

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 25, 2020
@jyn514jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc labels Aug 25, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 27, 2020
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Aug 28, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 29, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 29, 2020
@bors

bors commented Aug 30, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f20f7f2 with merge 99b4a01...

@bors

bors commented Aug 30, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: pickfire
Pushing 99b4a01 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 30, 2020
@bors
bors merged commit 99b4a01 into rust-lang:masterAug 30, 2020
@GuillaumeGomez
GuillaumeGomez deleted the ayu-theme-button-hover-background-color branch August 30, 2020 09:22
@cuvipercuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-themesArea: Themes for HTML pages generated by rustdocmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ayu theme hover not noticible

5 participants

@GuillaumeGomez@bors@pickfire@cuviper@jyn514