Skip to content

Applied #![deny(unsafe_op_in_unsafe_fn)] in library/std/src/wasi - #75971

Merged
bors merged 1 commit into
rust-lang:masterfrom
Amjad50:libstd-deny-unsafe_op_in_unsafe_fn
Sep 3, 2020
Merged

Applied #![deny(unsafe_op_in_unsafe_fn)] in library/std/src/wasi#75971
bors merged 1 commit into
rust-lang:masterfrom
Amjad50:libstd-deny-unsafe_op_in_unsafe_fn

Conversation

@Amjad50

@Amjad50Amjad50 commented Aug 27, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

partial fix for #73904

There are still more that was not applied in mod.rs and that is due to its using files from ../unsupported

like:

#[path = "../unsupported/cmath.rs"]
pub mod cmath;

@rust-highfive

rust-highfive commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2020
@Amjad50

Amjad50 commented Aug 28, 2020

Copy link
Copy Markdown
ContributorAuthor

r? @Mark-Simulacrum

Mark-Simulacrum
Mark-Simulacrum reviewed Aug 28, 2020
View reviewed changes
Comment threadlibrary/std/src/sys/wasi/alloc.rs Outdated
@Mark-SimulacrumMark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2020
Amjad50
Amjad50 commented Aug 30, 2020
View reviewed changes
Comment threadlibrary/std/src/sys/wasi/alloc.rs Outdated
@Amjad50

Amjad50 commented Sep 1, 2020

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum ?

Mark-Simulacrum
Mark-Simulacrum reviewed Sep 2, 2020
View reviewed changes

@Mark-SimulacrumMark-Simulacrum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed and commits squashed

Comment threadlibrary/std/src/sys/wasi/alloc.rs Outdated
Comment threadlibrary/std/src/sys/wasi/alloc.rs Outdated
Mark-Simulacrum
Mark-Simulacrum reviewed Sep 2, 2020
View reviewed changes
Comment threadlibrary/std/src/sys/wasi/alloc.rs Outdated
@Mark-Simulacrum

Mark-Simulacrum commented Sep 2, 2020

Copy link
Copy Markdown
Member

r=me with commits squashed, likely into one

@Amjad50

Amjad50 commented Sep 2, 2020

Copy link
Copy Markdown
ContributorAuthor

should I force push them into one?

@Mark-Simulacrum

Mark-Simulacrum commented Sep 3, 2020

Copy link
Copy Markdown
Member

Yep!

@Amjad50
Applied #![deny(unsafe_op_in_unsafe_fn)] in library/std/src/wasi
559679b
All refactoring needed was only in `alloc.rs`, changed part of the code
in `alloc` method to satisfy the SAFETY statement
@Amjad50
Amjad50force-pushed the libstd-deny-unsafe_op_in_unsafe_fn branch from b8d86e2 to 559679bCompareSeptember 3, 2020 00:29
@Mark-Simulacrum

Mark-Simulacrum commented Sep 3, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 559679b has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2020
@bors

bors commented Sep 3, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 559679b with merge 1e33c74...

@bors

bors commented Sep 3, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 1e33c74 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2020
@bors
bors merged commit 1e33c74 into rust-lang:masterSep 3, 2020
@borsbors mentioned this pull request Sep 3, 2020
Merged
@LeSeulArtichautLeSeulArtichaut mentioned this pull request Sep 5, 2020
Closed
22 tasks
@cuvipercuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments
@Mark-SimulacrumMark-SimulacrumAwaiting requested review from Mark-Simulacrum

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Amjad50@rust-highfive@Mark-Simulacrum@bors@Amanieu@cuviper@shepmaster