Uh oh!
There was an error while loading. Please reload this page.
Revert "Make libunwind build hermetic" - #76026
Closed
Keruspe wants to merge 1 commit into
Closed
Conversation
This reverts commit 21abc88. Fixesrust-lang#76020
rust-highfive
commented
Aug 28, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Keruspe
commented
Aug 28, 2020
ContributorAuthor
cc @petrhosek |
Keruspe
commented
Sep 3, 2020
ContributorAuthor
Dylan-DPC-zz
commented
Oct 8, 2020
tmandry
commented
Oct 8, 2020
Member
This would end up breaking Fuchsia; #76020 (comment) has more details and talks about how to fix that bug correctly. |
Keruspe
commented
Oct 8, 2020
ContributorAuthor
Let's close this and explore other options such as #77703 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 21abc88.
Fixes#76020
I'm not sure what exact problem #72746 is supposed to fix, but it's probably incomplete as it breaks the build of 1.46.0 with llvm-libunwind enabled