Uh oh!
There was an error while loading. Please reload this page.
Refactor io/buffered.rs into submodules - #76084
Merged
Merged
Conversation
bors
commented
Aug 31, 2020
Collaborator
☔ The latest upstream changes (presumably #75979) made this pull request unmergeable. Please resolve the merge conflicts. |
Lucretiel
commented
Sep 1, 2020
ContributorAuthor
Ouch. Whelp, alright, let's try that again. |
Lucretielforce-pushed
the
split-buffered
branch
from
September 11, 2020 03:52
1aae49c to
96229f0Comparejonas-schievink
commented
Sep 13, 2020
Contributor
r? @BurntSushi |
Lucretiel
commented
Sep 18, 2020
ContributorAuthor
@BurntSushi got all the checks passing, but no rush |
Lucretiel
commented
Oct 7, 2020
ContributorAuthor
This is tagged as waiting-on-author, but I don't see any outstanding issues for me to address. |
dtolnay
commented
Oct 15, 2020
Member
@jonas-schievink, I don't think BurntSushi has been able to do standard library reviews recently. r? @dtolnay |
dtolnay
approved these changes
Oct 15, 2020
dtolnay
left a comment
Member
There was a problem hiding this comment.
Thank you, this looks good to me.
dtolnay
commented
Oct 15, 2020
Member
@bors r+ |
bors
commented
Oct 15, 2020
Collaborator
📌 Commit c4280af has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Oct 15, 2020
Refactor io/buffered.rs into submodules This pull request splits `BufWriter`, `BufReader`, `LineWriter`, and `LineWriterShim` (along with their associated tests) into separate submodules. It contains no functional changes. This change is being made in anticipation of adding another type of buffered writer which can be switched between line- and block-buffering mode. Part of a series of pull requests resolving rust-lang#60673.
This was referenced Oct 15, 2020
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#75023 (ensure arguments are included in count mismatch span) - rust-lang#75265 (Add `str::{Split,RSplit,SplitN,RSplitN,SplitTerminator,RSplitTerminator,SplitInclusive}::as_str` methods) - rust-lang#75675 (mangling: mangle impl params w/ v0 scheme) - rust-lang#76084 (Refactor io/buffered.rs into submodules) - rust-lang#76119 (Stabilize move_ref_pattern) - rust-lang#77493 (ICEs should always print the top of the query stack) - rust-lang#77619 (Use futex-based thread-parker for Wasm32.) - rust-lang#77646 (For backtrace, use StaticMutex instead of a raw sys Mutex.) - rust-lang#77648 (Static mutex is static) - rust-lang#77657 (Cleanup cloudabi mutexes and condvars) - rust-lang#77672 (Simplify doc-cfg rendering based on the current context) - rust-lang#77780 (rustc_parse: fix spans on cast and range exprs with attrs) - rust-lang#77935 (BTreeMap: make PartialCmp/PartialEq explicit and tested) - rust-lang#77980 (Fix intra doc link for needs_drop) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request splits
BufWriter,BufReader,LineWriter, andLineWriterShim(along with their associated tests) into separate submodules. It contains no functional changes. This change is being made in anticipation of adding another type of buffered writer which can be switched between line- and block-buffering mode.Part of a series of pull requests resolving #60673.