Skip to content

Remove MMX from Rust - #76295

Merged
bors merged 1 commit into
rust-lang:masterfrom
mati865:remove-mmx
Sep 21, 2020
Merged

Remove MMX from Rust #76295
bors merged 1 commit into
rust-lang:masterfrom
mati865:remove-mmx

Conversation

@mati865

@mati865mati865 commented Sep 3, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Follow-up to rust-lang/stdarch#890
This removes most of MMX from Rust (tests pass with small changes), keeping stable is_x86_feature_detected!("mmx") working.

@rust-highfive

rust-highfive commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2020
@mati865

mati865 commented Sep 3, 2020

Copy link
Copy Markdown
MemberAuthor

cc @Amanieu

nikic
nikic reviewed Sep 3, 2020
View reviewed changes
Comment threadcompiler/rustc_codegen_llvm/src/llvm/ffi.rs Outdated
Amanieu
Amanieu reviewed Sep 3, 2020
View reviewed changes
Comment threadcompiler/rustc_codegen_llvm/src/type_of.rs Outdated
@jyn514jyn514 added the A-codegen Area: Code generation label Sep 3, 2020
@mati865

mati865 commented Sep 4, 2020

Copy link
Copy Markdown
MemberAuthor

Updated, I'll squash commits afterwards.

@mati865
mati865 marked this pull request as ready for review September 4, 2020 08:13
@bors

This comment has been minimized.

Sign in to view
@bors

bors commented Sep 15, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #73166) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

This was referenced Sep 19, 2020
Closed
Closed
@danieldjewell

danieldjewell commented Sep 19, 2020

Copy link
Copy Markdown

Can someone please double check the above referenced issues in rust-lang/packed_simd and ripgrep? If these changes did make it into nightly on 2020-09-15 then this change would appear to be the root cause of the compilation failures.

@Amanieu

Amanieu commented Sep 19, 2020

Copy link
Copy Markdown
Member

LGTM but probably needs a sign-off from @rust-lang/compiler.

@oli-obk

oli-obk commented Sep 20, 2020

Copy link
Copy Markdown
Contributor

@bors r=Amanieu,oli-obk

@bors

bors commented Sep 20, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 4f8e1c60aa5e1eb2f43f93021d9d1e2da6ac4ae9 has been approved by Amanieu,oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2020
@mati865

mati865 commented Sep 20, 2020

Copy link
Copy Markdown
MemberAuthor

Don't you want me to squash commits first?

I left them to make review easier but this causes mess in git history.

@oli-obk

oli-obk commented Sep 20, 2020

Copy link
Copy Markdown
Contributor

@bors r-

@bors delegate+

Sure, feel free to r=Amanieu,oli-obk after squashing

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2020
@bors

bors commented Sep 20, 2020

Copy link
Copy Markdown
Collaborator

✌️ @mati865 can now approve this pull request

@mati865

mati865 commented Sep 20, 2020

Copy link
Copy Markdown
MemberAuthor

@bors r=Amanieu,oli-obk

@bors

bors commented Sep 20, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5de2c95 has been approved by Amanieu,oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2020
@RalfJung

RalfJung commented Sep 20, 2020

Copy link
Copy Markdown
Member

@bors rollup=iffy

@bors

bors commented Sep 21, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5de2c95 with merge 0f9f0b3...

@bors

bors commented Sep 21, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu,oli-obk
Pushing 0f9f0b3 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 21, 2020
@bors
bors merged commit 0f9f0b3 into rust-lang:masterSep 21, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 21, 2020
@mati865
mati865 deleted the remove-mmx branch September 21, 2020 06:33
@Aaron1011Aaron1011 mentioned this pull request Sep 21, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikicnikicnikic left review comments
@AmanieuAmanieuAmanieu left review comments

Assignees

@nikomatsakisnikomatsakis

Labels

A-codegenArea: Code generationmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

11 participants

@mati865@rust-highfive@bors@danieldjewell@Amanieu@oli-obk@RalfJung@nikic@nikomatsakis@jyn514@rustbot