Uh oh!
There was an error while loading. Please reload this page.
rustbuild: Build tests with LLD if use-lld = true was passed - #76378
Conversation
rust-highfive
commented
Sep 5, 2020
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
mati865
commented
Sep 8, 2020
Could you also update this line? Line 432 in 35fc835 |
petrochenkov
commented
Sep 8, 2020
Done. |
Mark-Simulacrum
commented
Sep 9, 2020
@bors r+ |
bors
commented
Sep 9, 2020
📌 Commit 75a2c68 has been approved by |
bors
commented
Sep 10, 2020
rust-log-analyzer
commented
Sep 10, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Sep 10, 2020
☀️ Test successful - checks-actions, checks-azure |
Addresses #76127 (comment).
Our test suite is generally ready to run with an explicitly specified linker (#45191),
so LLD specified with
use-lld = trueworks as well.Only 4 tests fail (on
x86_64-pc-windows-msvc):All of them are legitimate issues with LLD (or at least with combination Rust+LLD) and manifest in segfaults on access to TLS (#76127 (comment)). UPD: These issues are caused by #72145 and appear because I had
-Ctarget-cpu=nativeset.UPD: Further commits build tests with LLD for non-MSVC targets and propagate LLD to more places when
use-lldis enabled.