Uh oh!
There was an error while loading. Please reload this page.
add the const_evaluatable_checked feature - #76559
Merged
Merged
Conversation
oli-obk
reviewed
Sep 10, 2020
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
commented
Sep 10, 2020
Contributor
You have some CI failures |
oli-obk
commented
Sep 10, 2020
Contributor
bors
commented
Sep 10, 2020
Collaborator
📌 Commit 300b0ac has been approved by |
lcnr
commented
Sep 10, 2020
ContributorAuthor
@bors rollup |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#75857 (Syntactically permit unsafety on mods) - rust-lang#76289 (Add docs about crate level documentation support) - rust-lang#76514 (Add revisions to const generic issue UI tests.) - rust-lang#76524 (typeck: don't suggest inaccessible private fields) - rust-lang#76548 (Validate removal of AscribeUserType, FakeRead, and Shallow borrow) - rust-lang#76555 (Reword `trivial_casts` lint in rustc book to better explain what it does.) - rust-lang#76559 (add the `const_evaluatable_checked` feature) - rust-lang#76563 (small typo fix in rustc_parse docs) - rust-lang#76565 (take reference to Place directly instead of taking reference to Box<Place>) - rust-lang#76567 (use push(char) to add chars (single-char &strs) to strings instead of push_str(&str)) - rust-lang#76568 (Add missing examples on core traits' method) Failed merges: r? `@ghost`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2020
compare generic constants using `AbstractConst`s This is a MVP of rust-lang/compiler-team#340. The changes in this PR should only be relevant if `feature(const_evaluatable_checked)` is enabled. ~~currently based on top of rust-lang#76559, so blocked on that.~~ r? `@oli-obk` cc `@varkor` `@eddyb`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a rather small subset of rust-lang/compiler-team#340
Unlike the MCP, this does not try to compare different constant, but instead only adds the constants found in where clauses
to the predicates of a function. This PR adds the feature gate
const_evaluatable_checked, without which nothing should change.r? @oli-obk@eddyb