Uh oh!
There was an error while loading. Please reload this page.
Use IOV_MAX and UIO_MAXIOV constants in limit vectored I/O - #76561
Conversation
Thomasdezeeuw
commented
Sep 10, 2020
CI failed due to clock drift, could someone restart it? |
You have to update Cargo.lock too: |
Thomasdezeeuw
commented
Sep 10, 2020
@lzutao I'm ok with doing that, but how is that related to the clock drift? Also I couldn't get it to only update the libc dependency, is alright to update other dependencies as well? |
I don't know what clock drift is, but the main problem why CI failed is that Running |
Thomasdezeeuw
commented
Sep 10, 2020
Clock drift is when the local clock's reported time differs from the "correct" time as reported by a known good clock.
This failed initially, but I got it to work. Thanks. |
Also updates the libc dependency to 0.2.77 (from 0.2.74) as the constants were only recently added.
Thomasdezeeuw
commented
Sep 10, 2020
CI is complaining about an unneeded unsafe block in |
Amanieu
commented
Sep 10, 2020
It's because you updated the libc dependency. You should fix these errors. |
Uh oh!
There was an error while loading. Please reload this page.
Thomasdezeeuw
commented
Sep 10, 2020
On macOS those function do require unsafe (that's why it didn't show up in my local testing). The definition on Linux: https://docs.rs/libc/0.2.77/libc/fn.WTERMSIG.html (no @Amanieu would you be ok with putting |
Amanieu
commented
Sep 10, 2020
Put it under a linux-only |
This is a work-around for a libc issue: rust-lang/libc#1888.
Thomasdezeeuw
commented
Sep 11, 2020
@Amanieu CI is now green. |
Amanieu
commented
Sep 11, 2020
@bors r+ |
bors
commented
Sep 11, 2020
📌 Commit c394624 has been approved by |
…r=Amanieu Use IOV_MAX and UIO_MAXIOV constants in limit vectored I/O Also updates the libc dependency to 0.2.77 (from 0.2.74) as the constants were only recently added. Related rust-lang#68042, rust-lang#75005 r? @Amanieu (also reviewed rust-lang#75005)
bors
commented
Sep 12, 2020
bors
commented
Sep 12, 2020
☀️ Test successful - checks-actions, checks-azure |
Also updates the libc dependency to 0.2.77 (from 0.2.74) as the
constants were only recently added.
Related #68042, #75005
r? @Amanieu (also reviewed #75005)