Uh oh!
There was an error while loading. Please reload this page.
Some cleanup changes and commenting - #76641
Merged
Merged
Conversation
noxforce-pushed
the
pointee-random-stuff
branch
from
September 12, 2020 12:24
96d770d to
ff5c5a6Comparenox
commented
Sep 12, 2020
ContributorAuthor
Seems like we forgot about nonsensical bounds in nonsensical code. That test does |
nox
commented
Sep 12, 2020
ContributorAuthor
I'll change that commit to be adding a comment explaining why we can't fast-path types that are trivially |
jyn514
reviewed
Sep 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
noxforce-pushed
the
pointee-random-stuff
branch
from
September 12, 2020 16:36
ff5c5a6 to
caf6c92Compareis_sized and drive-by improve a few thingsnox
commented
Sep 12, 2020
ContributorAuthor
I added a comment on |
eddyb
commented
Sep 12, 2020
Contributor
I want @nikomatsakis to see this (I forgot about trivial bounds too!), but also, we can: @bors rollup |
jyn514
commented
Sep 12, 2020
Member
@bors r=eddyb rollup |
bors
commented
Sep 12, 2020
Collaborator
📌 Commit caf6c92 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 12, 2020
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 12, 2020
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Sep 13, 2020
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Sep 13, 2020
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 16, 2020
Some cleanup changes and commenting r? @nikomatsakis Cc @eddyb
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#76056 (Add more info for Vec Drain doc) - rust-lang#76062 (Vec slice example fix style and show type elision) - rust-lang#76262 (Use inline(never) instead of cold) - rust-lang#76335 (Make all methods of `Duration` unstably const) - rust-lang#76366 (Add Arith Tests in Library) - rust-lang#76369 (Move Various str tests in library) - rust-lang#76534 (Add doc comments for From impls) - rust-lang#76622 (Update bootstrap readme) - rust-lang#76641 (Some cleanup changes and commenting) - rust-lang#76662 (Fix liballoc test suite for Miri) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis
Cc @eddyb