Uh oh!
There was an error while loading. Please reload this page.
don't convert types to the same type with try_into (clippy::useless_conversion) - #76757
Merged
Conversation
rust-highfive
commented
Sep 15, 2020
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
leonardo-m
commented
Sep 15, 2020
Is this lint good enough to have in rustc? |
lcnr
reviewed
Sep 16, 2020
Uh oh!
There was an error while loading. Please reload this page.
lcnr
commented
Sep 16, 2020
Contributor
r? @lcnr r=me after the nit is fixed |
matthiaskrgrforce-pushed
the
clippy_try_into
branch
from
September 16, 2020 19:50
e16fa5f to
af23c26CompareDylan-DPC-zz
commented
Sep 16, 2020
@matthiaskrgr CI is still failing |
…ts (clippy::unnecessary_lazy_evaluations)
matthiaskrgrforce-pushed
the
clippy_try_into
branch
from
September 16, 2020 23:38
af23c26 to
0e34142Comparematthiaskrgr
commented
Sep 16, 2020
MemberAuthor
Ah, forgot to run |
Dylan-DPC-zz
commented
Sep 17, 2020
@bors r=lcnr rollup |
bors
commented
Sep 17, 2020
Collaborator
📌 Commit 0e34142 has been approved by |
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Sep 19, 2020
don't convert types to the same type with try_into (clippy::useless_conversion)
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#73963 (deny(unsafe_op_in_unsafe_fn) in libstd/path.rs) - rust-lang#75099 (lint/ty: move fns to avoid abstraction violation) - rust-lang#75502 (Use implicit (not explicit) rules for promotability by default in `const fn`) - rust-lang#75580 (Add test for checking duplicated branch or-patterns) - rust-lang#76310 (Add `[T; N]: TryFrom<Vec<T>>` (insta-stable)) - rust-lang#76400 (Clean up vec benches bench_in_place style) - rust-lang#76434 (do not inline black_box when building for Miri) - rust-lang#76492 (Add associated constant `BITS` to all integer types) - rust-lang#76525 (Add as_str() to string::Drain.) - rust-lang#76636 (assert ScalarMaybeUninit size) - rust-lang#76749 (give *even better* suggestion when matching a const range) - rust-lang#76757 (don't convert types to the same type with try_into (clippy::useless_conversion)) - rust-lang#76796 (Give a better error message when x.py uses the wrong stage for CI) - rust-lang#76798 (Build fixes for RISC-V 32-bit Linux support) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.