Skip to content

Use intra-doc links in core/src/iter when possible - #76867

Merged
bors merged 3 commits into
rust-lang:masterfrom
poliorcetics:intra-doc-core-iter
Sep 21, 2020
Merged

Use intra-doc links in core/src/iter when possible#76867
bors merged 3 commits into
rust-lang:masterfrom
poliorcetics:intra-doc-core-iter

Conversation

@poliorcetics

@poliorceticspoliorcetics commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

Helps with #75080.

I also updated lots of links to use fn() instead of fn when possible.

@rustbot modify labels: T-doc A-intra-doc-links

r? @jyn514

@rustbotrustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Sep 18, 2020
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2020
jyn514
jyn514 reviewed Sep 18, 2020
View reviewed changes
Comment threadlibrary/core/src/iter/sources.rs Outdated
Comment threadlibrary/core/src/iter/sources.rs Outdated
@pickfire

pickfire commented Sep 18, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

@poliorcetics I have a patch for sources too #76816 but I was inclined to move them to fn() since I just put them as fn, note that I also changed the text a bit..

@dtolnaydtolnay mentioned this pull request Sep 19, 2020
Closed
@jyn514jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2020
@poliorcetics

This comment has been minimized.

Sign in to view
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2020
@jyn514

jyn514 commented Sep 20, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

It would be nice to move from 'the function f' to 'f()' at some point, but that doesn't need to block this PR.

@bors

bors commented Sep 20, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 08b85a6 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 21, 2020
@Dylan-DPC
Rollup merge ofrust-lang#76867- poliorcetics:intra-doc-core-iter, r…
b7dc6d5
…=jyn514
Use intra-doc links in core/src/iter when possible
Helps with rust-lang#75080.
I also updated lots of links to use `fn()` instead of `fn` when possible.
@rustbot modify labels: T-doc A-intra-doc-links
r? @jyn514
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Sep 21, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 21, 2020
@Dylan-DPC
Rollup merge ofrust-lang#76867- poliorcetics:intra-doc-core-iter, r…
de4f13c
…=jyn514
Use intra-doc links in core/src/iter when possible
Helps with rust-lang#75080.
I also updated lots of links to use `fn()` instead of `fn` when possible.
@rustbot modify labels: T-doc A-intra-doc-links
r? @jyn514
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Sep 21, 2020
Closed
pickfire
pickfire reviewed Sep 21, 2020
View reviewed changes
Comment threadlibrary/core/src/iter/sources.rs
/// applying the provided closure `F: FnOnce() -> A`.
///
/// This `struct` is created by the [`once_with`] function.
/// This `struct` is created by the [`once_with()`] function.

@pickfirepickfireSep 21, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// This `struct` is created by the [`once_with()`] function.
/// This `struct` is created by [`iter::once_with()`].

Based on #76816 comments

RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 21, 2020
@RalfJung
Rollup merge ofrust-lang#76867- poliorcetics:intra-doc-core-iter, r…
d93e2b6
…=jyn514
Use intra-doc links in core/src/iter when possible
Helps with rust-lang#75080.
I also updated lots of links to use `fn()` instead of `fn` when possible.
@rustbot modify labels: T-doc A-intra-doc-links
r? @jyn514
@RalfJungRalfJung mentioned this pull request Sep 21, 2020
Closed
@RalfJungRalfJung mentioned this pull request Sep 21, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2020
@bors
Auto merge ofrust-lang#77004- RalfJung:rollup-usac4nv, r=RalfJung
956e06c
Rollup of 13 pull requests
Successful merges:
- rust-lang#76135 (Stabilize some Option methods as const)
- rust-lang#76628 (Add sample defaults for config.toml )
- rust-lang#76846 (Avoiding unnecesary allocations at rustc_errors)
- rust-lang#76867 (Use intra-doc links in core/src/iter when possible)
- rust-lang#76868 (Finish moving to intra doc links for std::sync)
- rust-lang#76872 (Remove DeclareMethods)
- rust-lang#76936 (Add non-`unsafe` `.get_mut()` for `Unsafecell`)
- rust-lang#76958 (Replace manual as_nanos and as_secs_f64 reimplementations)
- rust-lang#76959 (Replace write_fmt with write!)
- rust-lang#76961 (Add test for issue rust-lang#34634)
- rust-lang#76962 (Use const_cstr macro in consts.rs)
- rust-lang#76963 (Remove unused static_assert macro)
- rust-lang#77000 (update Miri)
Failed merges:
r? `@ghost`
@bors
bors merged commit 5031242 into rust-lang:masterSep 21, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 21, 2020
@poliorcetics
poliorcetics deleted the intra-doc-core-iter branch September 21, 2020 19:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@pickfirepickfirepickfire left review comments
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jyn514jyn514

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

6 participants

@poliorcetics@pickfire@jyn514@bors@rust-highfive@rustbot