Uh oh!
There was an error while loading. Please reload this page.
LVI hardening tests - #77008
Conversation
rust-highfive
commented
Sep 21, 2020
(rust_highfive has picked a reviewer for you, use r? to override) |
6026a2f to
e3ae538CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
commented
Sep 24, 2020
It looks like some of this is testing C and C++ LVI, as well, which seems a bit out of place for this repository? Could you elaborate why those tests are added? |
The old CMakeLists file of libunwind used the C compiler to compile assembly files. This caused such code not to be hardened.
raoulstrackx
commented
Sep 25, 2020
For the |
e3ae538 to
159d11fCompareMark-Simulacrum
commented
Sep 25, 2020
Okay, I think this is reasonable. It's not too many additional tests and they're SGX only so I'm not too worried in that respect either. @bors r+ rollup=iffy |
bors
commented
Sep 25, 2020
📌 Commit 159d11f has been approved by |
bors
commented
Sep 26, 2020
⌛ Testing commit 159d11f with merge 032ab1893ec16166331dc85d0b56456bf5442a39... |
rust-log-analyzer
commented
Sep 26, 2020
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Sep 26, 2020
💔 Test failed - checks-actions |
kennytm
commented
Sep 27, 2020
@bors retry https://github.com/rust-lang-ci/rust/runs/1169263815 |
bors
commented
Sep 28, 2020
bors
commented
Sep 28, 2020
☀️ Test successful - checks-actions, checks-azure |
Mitigating the speculative execution LVI attack against SGX enclaves requires compiler changes (i.e., adding lfences). This pull requests adds various tests to check if this happens correctly.