perf: move cold path of process_obligations into a separate function

[lcnr]

cc #76575

This probably won't matter too much in the long run once #69218 is merged so we may not want to merge this.

r? @ecstatic-morse

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion

[bors]

⌛ Trying commit 8f7c42bf82ac9649f17b2d709b30264d535338c4 with merge 3943bf088dc91b49ad11f4b16e68f7831e71355a...

[bors]

☀️ Try build successful - checks-actions, checks-azure
Build commit: 3943bf088dc91b49ad11f4b16e68f7831e71355a (3943bf088dc91b49ad11f4b16e68f7831e71355a)

[rust-timer]

Queued 3943bf088dc91b49ad11f4b16e68f7831e71355a with parent 4519845, future comparison URL.

[rust-timer]

Finished benchmarking try commit (3943bf088dc91b49ad11f4b16e68f7831e71355a): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

[lcnr]

let's try something else...

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion

[bors]

⌛ Trying commit 923b1da2976f355926bea98490a8323e031642cb with merge 6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52...

[bors]

☀️ Try build successful - checks-actions, checks-azure
Build commit: 6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52 (6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52)

[rust-timer]

Queued 6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52 with parent e0bc267, future comparison URL.

[rust-timer]

Finished benchmarking try commit (6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion

[bors]

⌛ Trying commit f0c3c6439d9e42aa2d158728e8d79eb2fec79615 with merge 6b31c91ac8796e36a3f86a5feec9b5a78517bfc7...

[bors]

☀️ Try build successful - checks-actions, checks-azure
Build commit: 6b31c91ac8796e36a3f86a5feec9b5a78517bfc7 (6b31c91ac8796e36a3f86a5feec9b5a78517bfc7)

[rust-timer]

Queued 6b31c91ac8796e36a3f86a5feec9b5a78517bfc7 with parent 87d262a, future comparison URL.

[rust-timer]

Finished benchmarking try commit (6b31c91ac8796e36a3f86a5feec9b5a78517bfc7): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

[lcnr]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 06d2325 with merge 74f84cdf746e754004f0df926a23c1d5c9113b77...

[bors]

☀️ Try build successful - checks-actions, checks-azure
Build commit: 74f84cdf746e754004f0df926a23c1d5c9113b77 (74f84cdf746e754004f0df926a23c1d5c9113b77)

[lcnr]

Was rust-perf down?

@rust-timer build 74f84cdf746e754004f0df926a23c1d5c9113b77

[rust-timer]

Queued 74f84cdf746e754004f0df926a23c1d5c9113b77 with parent e599b53, future comparison URL.

[rust-timer]

Finished benchmarking try commit (74f84cdf746e754004f0df926a23c1d5c9113b77): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

[ecstatic-morse]

Really nice work here @lcnr. I'll cc @Marwes since maybe they can do (or have done) something similar in #69218.

r=me once you're happy.

[lcnr]

hmm, yeah

Let's just merge this, rebasing #69218 on top of this hopefully won't be an issue. Probably only useful for a few days though, considering that #69218 makes these changes obsolete, as the outer loop won't exist anymore.

@bors r+ rollup=never

[bors]

📌 Commit 06d2325 has been approved by lcnr

[lcnr]

@bors r-
@bors r=ecstatic-morse

[bors]

📌 Commit 06d2325 has been approved by ecstatic-morse

[bors]

⌛ Testing commit 06d2325 with merge 521d8d8...

[bors]

☀️ Test successful - checks-actions, checks-azure
Approved by: ecstatic-morse
Pushing 521d8d8 to master...