const_evaluatable_checked: extend predicate collection

[lcnr]

We now walk the hir instead of using ty so that we get better spans here, While I am still not completely sure if that's
what we want in the end, it does seem a lot closer to the final goal than the previous version.

We also look into type aliases (and use a TypeVisitor here), about which I am not completely sure, but we will see how well this works.

We also look into fn decls, so the following should work now.

fntest<T>() -> [u8; std::mem::size_of::<T>()]{[0; std::mem::size_of::<T>()]}

Additionally, we visit the optional trait and self type of impls.

r? @oli-obk

[oli-obk]

Can we somehow tell the user that this is speciically about test<0>?

I mean ideally we could report this on the call site

[lcnr]

Yeah, we should. Will do so in another PR though.

[lcnr]

Added a commit which assigns the correct DefId in nominal obligations, I was unable to test these changes without const_evaluatable_checked so I left them as part of this PR.

We probably need a perf run for that, but we should be able to optimize it without issue.

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion

[bors]

⌛ Trying commit 7f8d8ae26ed96b7e283f215b870bd0a8323354cb with merge 8b29e63e47b49b0147a2ca5973bf66f00e90c2b2...

[bors]

☀️ Try build successful - checks-actions, checks-azure
Build commit: 8b29e63e47b49b0147a2ca5973bf66f00e90c2b2 (8b29e63e47b49b0147a2ca5973bf66f00e90c2b2)

[rust-timer]

Queued 8b29e63e47b49b0147a2ca5973bf66f00e90c2b2 with parent f6d5920, future comparison URL.

[rust-timer]

Finished benchmarking try commit (8b29e63e47b49b0147a2ca5973bf66f00e90c2b2): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

[oli-obk]

@bors rollup-

[oli-obk]

r=me with a test demonstrating the type alias situation

[oli-obk]

@bors r+

[bors]

📌 Commit 7f8d8ae26ed96b7e283f215b870bd0a8323354cb has been approved by oli-obk

[bors]

☔ The latest upstream changes (presumably #77102) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[lcnr]

rebased and updated test output

@bors r=oli-obk

[bors]

📌 Commit 21edd10 has been approved by oli-obk

[bors]

⌛ Testing commit 21edd10 with merge 3a4da87...

[bors]

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 3a4da87 to master...