Skip to content

Stabilize slice_ptr_range. - #77111

Merged
bors merged 1 commit into
rust-lang:masterfrom
fusion-engineering-forks:stabilize-slice-ptr-range
Oct 2, 2020
Merged

Stabilize slice_ptr_range.#77111
bors merged 1 commit into
rust-lang:masterfrom
fusion-engineering-forks:stabilize-slice-ptr-range

Conversation

@m-ou-se

@m-ou-sem-ou-se commented Sep 23, 2020

Copy link
Copy Markdown
Member

This has been unstable for almost a year now. Time to stabilize?

Closes#65807.

@rustbot modify labels: +T-libs +A-raw-pointers +A-slice +needs-fcp

@rustbot

rustbot commented Sep 23, 2020

Copy link
Copy Markdown
Collaborator

Error: Label needs-fcp can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@rust-highfive

rust-highfive commented Sep 23, 2020

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 23, 2020
@rustbotrustbot added A-raw-pointers Area: raw pointers, MaybeUninit, NonNull A-slice Area: `[T]` T-libs-api [DEPRECATED; DO NOT USE] labels Sep 23, 2020
@sfackler

sfackler commented Sep 23, 2020

Copy link
Copy Markdown
Member

@rfcbot fcp merge

@rfcbot

rfcbot commented Sep 23, 2020•
edited by BurntSushi
Loading

Copy link
Copy Markdown

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 23, 2020
@bors

bors commented Sep 25, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #77198) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@m-ou-se
m-ou-seforce-pushed the stabilize-slice-ptr-range branch from 3758402 to f289468CompareSeptember 25, 2020 22:26
@rfcbotrfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 29, 2020
@rfcbot

rfcbot commented Sep 29, 2020

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@dtolnay

dtolnay commented Oct 1, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f289468 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2020
@jeekobu

jeekobu commented Oct 1, 2020

Copy link
Copy Markdown

Stabilization report?

@JohnTitorJohnTitor added this to the 1.48.0 milestone Oct 1, 2020
@JohnTitorJohnTitor added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 1, 2020
@JohnTitorJohnTitor mentioned this pull request Oct 1, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 1, 2020
@Dylan-DPC
Rollup merge ofrust-lang#77111- fusion-engineering-forks:stabilize-…
bf59451
…slice-ptr-range, r=dtolnay
Stabilize slice_ptr_range.
This has been unstable for almost a year now. Time to stabilize?
Closesrust-lang#65807.
@rustbot modify labels: +T-libs +A-raw-pointers +A-slice +needs-fcp
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Oct 1, 2020
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 2, 2020
@bors
Auto merge ofrust-lang#77436- JohnTitor:rollup-65dh7rp, r=JohnTitor
f283d3f
Rollup of 11 pull requests
Successful merges:
- rust-lang#76851 (Fix 'FIXME' about using NonZeroU32 instead of u32.)
- rust-lang#76979 (Improve std::sys::windows::compat)
- rust-lang#77111 (Stabilize slice_ptr_range.)
- rust-lang#77147 (Split sys_common::Mutex in StaticMutex and MovableMutex.)
- rust-lang#77312 (Remove outdated line from `publish_toolstate` hook)
- rust-lang#77362 (Fix is_absolute on WASI)
- rust-lang#77375 (rustc_metadata: Do not forget to encode inherent impls for foreign types)
- rust-lang#77385 (Improve the example for ptr::copy)
- rust-lang#77389 (Fix some clippy lints)
- rust-lang#77399 (BTreeMap: use Unique::from to avoid a cast where type information exists)
- rust-lang#77429 (Link `new` method in `DefautHasher`s doc)
Failed merges:
r? `@ghost`
@bors
bors merged commit 9eaf536 into rust-lang:masterOct 2, 2020
@dtolnaydtolnay assigned dtolnay and unassigned sfacklerOct 2, 2020
@rfcbotrfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 9, 2020
@spastorinospastorino removed the to-announce Announce this issue on triage meeting label Oct 15, 2020
@m-ou-se
m-ou-se deleted the stabilize-slice-ptr-range branch November 19, 2020 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnaydtolnaydtolnay approved these changes

Assignees

@dtolnaydtolnay

Labels

A-raw-pointersArea: raw pointers, MaybeUninit, NonNullA-sliceArea: `[T]`disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for slice_ptr_range

10 participants

@m-ou-se@rustbot@rust-highfive@sfackler@rfcbot@bors@dtolnay@jeekobu@spastorino@JohnTitor