Skip to content

core::global_allocator docs link to std::alloc::GlobalAlloc - #77219

Merged
bors merged 1 commit into
rust-lang:masterfrom
mightyiam:issue_77100
Oct 5, 2020
Merged

core::global_allocator docs link to std::alloc::GlobalAlloc#77219
bors merged 1 commit into
rust-lang:masterfrom
mightyiam:issue_77100

Conversation

@mightyiam

@mightyiammightyiam commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

Closes#77100

@rust-highfive

rust-highfive commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2020
pickfire
pickfire reviewed Sep 26, 2020
View reviewed changes
Comment threadlibrary/core/src/macros/mod.rs Outdated
@mightyiammightyiam mentioned this pull request Sep 29, 2020
Closed
@jyn514jyn514 added A-allocators Area: Custom and system allocators A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Oct 4, 2020
@jyn514

jyn514 commented Oct 4, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit badf4af has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2020
@jyn514

jyn514 commented Oct 4, 2020

Copy link
Copy Markdown
Member

Thanks for working on this!

@jonas-schievinkjonas-schievink mentioned this pull request Oct 4, 2020
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Oct 5, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 5, 2020
@bors
Auto merge ofrust-lang#77557- Dylan-DPC:rollup-aib9ptp, r=Dylan-DPC
efbaa41
Rollup of 11 pull requests
Successful merges:
- rust-lang#75853 (Use more intra-doc-links in `core::fmt`)
- rust-lang#75928 (Remove trait_selection error message in specific case)
- rust-lang#76329 (Add check for doc alias attribute at crate level)
- rust-lang#77219 (core::global_allocator docs link to std::alloc::GlobalAlloc)
- rust-lang#77395 (BTreeMap: admit the existence of leaf edges in comments)
- rust-lang#77407 (Improve build-manifest to work with the improved promote-release)
- rust-lang#77426 (Include scope id in SocketAddrV6::Display)
- rust-lang#77439 (Fix missing diagnostic span for `impl Trait` with const generics, and add various tests for `min_const_generics` and `const_generics`)
- rust-lang#77471 (BTreeMap: refactoring around edges, missed spots)
- rust-lang#77512 (Allow `Abort` terminators in all const-contexts)
- rust-lang#77514 (Replace some once(x).chain(once(y)) with [x, y] IntoIter)
Failed merges:
r? `@ghost`
@bors
bors merged commit 583269d into rust-lang:masterOct 5, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@yoshuawuytsyoshuawuytsyoshuawuyts left review comments
@pickfirepickfirepickfire left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@withoutboatswithoutboats

Labels

A-allocatorsArea: Custom and system allocatorsA-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

[docs] core::global_allocator should link to std::alloc::GlobalAlloc

8 participants

@mightyiam@rust-highfive@jyn514@bors@yoshuawuyts@pickfire@withoutboats@rustbot