Skip to content

try enabling typeof for fun error messages - #77246

Merged
bors merged 4 commits into
rust-lang:masterfrom
yaahc:typeof-errors
Apr 27, 2021
Merged

try enabling typeof for fun error messages#77246
bors merged 4 commits into
rust-lang:masterfrom
yaahc:typeof-errors

Conversation

@yaahc

@yaahcyaahc commented Sep 26, 2020

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2020
@yaahc
yaahc marked this pull request as draft September 26, 2020 23:34
@yaahc

yaahc commented Sep 26, 2020

Copy link
Copy Markdown
MemberAuthor

r? @eddyb

@rust-highfiverust-highfive assigned eddyb and unassigned varkorSep 26, 2020
@Dylan-DPC-zz

Dylan-DPC-zz commented Oct 23, 2020

Copy link
Copy Markdown

@yaahc if you can fix the CI we can take this pr forward

@Dylan-DPC-zzDylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020
@yaahc

yaahc commented Oct 23, 2020

Copy link
Copy Markdown
MemberAuthor

@yaahc if you can fix the CI we can take this pr forward

@Dylan-DPC it will probably be a bit before I get to this but 👍

@oli-obk

oli-obk commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

r? @oli-obk

if you want, we can also close this PR and open an E-easy issue. Then someone can copy your PR and update all the tests (or write some more)

@rust-highfiverust-highfive assigned oli-obk and unassigned eddybDec 28, 2020
@yaahc

yaahc commented Dec 29, 2020

Copy link
Copy Markdown
MemberAuthor

r? @oli-obk

if you want, we can also close this PR and open an E-easy issue. Then someone can copy your PR and update all the tests (or write some more)

I think I want to try to finish this one, since I know it's supposed to be easy.

@jyn514

jyn514 commented Apr 16, 2021

Copy link
Copy Markdown
Member

@yaahc are you still planning to work on this?

@yaahc

yaahc commented Apr 16, 2021

Copy link
Copy Markdown
MemberAuthor

yea, sorry about that, this fell off my radar completely but I have a lot more bandwidth for this now (once I get a working dev machine setup again, laptop battery started expanding a couple days ago). So yea, to answer your question, yes, still planning on working on this and soon.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yaahc
yaahc marked this pull request as ready for review April 23, 2021 21:36
@yaahcyaahc added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 23, 2021
@oli-obk

oli-obk commented Apr 24, 2021

Copy link
Copy Markdown
Contributor

The impl lgtm. Please add a test showcasing the new error messages

@oli-obk

oli-obk commented Apr 27, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 27, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit ed903f9 has been approved by oli-obk

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2021
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 27, 2021
@bors

bors commented Apr 27, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ed903f9 with merge 22b686a...

@bors

bors commented Apr 27, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 22b686a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2021
@bors
bors merged commit 22b686a into rust-lang:masterApr 27, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 27, 2021
@borsbors mentioned this pull request Apr 27, 2021
Merged
@yaahc
yaahc deleted the typeof-errors branch April 27, 2021 14:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

10 participants

@yaahc@rust-highfive@Dylan-DPC-zz@oli-obk@jyn514@rust-log-analyzer@bors@eddyb@varkor@rustbot