Uh oh!
There was an error while loading. Please reload this page.
Stabilize Option::unwrap_none and Option::expect_none - #77326
Closed
Aaron1011 wants to merge 1 commit into
Closed
Conversation
rust-highfive
commented
Sep 29, 2020
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
cc rust-lang#62633 These methods have been on nightly for over a year without any issues.
Aaron1011force-pushed
the
stabilize-option-none
branch
from
September 29, 2020 05:28
efa48b5 to
5a6df49Comparecuviper
commented
Sep 30, 2020
Member
I'm in favor, but there was some debate in #73077. |
Aaron1011
commented
Sep 30, 2020
ContributorAuthor
I somehow missed that other PR when I read through the tracking issue. |
poliorcetics
commented
Dec 2, 2020
Contributor
I really don’t like those methods over |
bors
commented
Jan 26, 2021
Collaborator
☔ The latest upstream changes (presumably #81417) made this pull request unmergeable. Please resolve the merge conflicts. |
m-ou-se
commented
Feb 17, 2021
Member
Closing this because of #62633 (comment). (Not closing the tracking issue yet. More discussion is still welcome there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #62633
These methods have been on nightly for over a year without any issues.