Skip to content

[beta][clippy] backport multiple FP fixes for a warn-by-default lint - #77403

Merged
bors merged 8 commits into
rust-lang:betafrom
flip1995:beta
Oct 1, 2020
Merged

[beta][clippy] backport multiple FP fixes for a warn-by-default lint#77403
bors merged 8 commits into
rust-lang:betafrom
flip1995:beta

Conversation

@flip1995

@flip1995flip1995 commented Oct 1, 2020

Copy link
Copy Markdown
Member

This backports the PR rust-lang/rust-clippy#6016 fixing multiple FPs:

rust-lang/rust-clippy#5902
rust-lang/rust-clippy#5979
rust-lang/rust-clippy#5985

We didn't have any complaints about this lint, since me merged this PR.

cc @ebroto (sorry I forgot about this, since we talked about the backport 3 weeks ago 😐)

r? @pietroalbini

@rust-highfive

rust-highfive commented Oct 1, 2020

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2020
@emilyalbini

emilyalbini commented Oct 1, 2020

Copy link
Copy Markdown
Member

@bors r+ p=10 rollup=never

@bors

bors commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 4a91098 has been approved by pietroalbini

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2020
@bors

bors commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4a91098 with merge 06bcf4d722aaf93e0d95b05e54fa4e0ff2466b23...

@rust-log-analyzer

rust-log-analyzer commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

The job i686-msvc-2 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@emilyalbini

emilyalbini commented Oct 1, 2020

Copy link
Copy Markdown
Member

Spurious failure.

@bors retry

@bors

bors commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4a91098 with merge 03de2742e0f7e4d5628e1367f7551f487ab07ce7...

@bors

bors commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2020
@flip1995

flip1995 commented Oct 1, 2020

Copy link
Copy Markdown
MemberAuthor

Again the same error? 🤔

Caused by:
failed to fetch `https://github.com/rust-lang/crates.io-index`
Caused by:
error inflating zlib stream; class=Zlib (5)

@emilyalbini

emilyalbini commented Oct 1, 2020

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2020
@bors

bors commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4a91098 with merge e28d2bd...

@bors

bors commented Oct 1, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing e28d2bd to beta...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 1, 2020
@bors
bors merged commit e28d2bd into rust-lang:betaOct 1, 2020
@rustbotrustbot added this to the 1.47.0 milestone Oct 1, 2020
@ebrotoebroto mentioned this pull request Oct 25, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emilyalbiniemilyalbini

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

7 participants

@flip1995@rust-highfive@emilyalbini@bors@rust-log-analyzer@rustbot@giraffate