Uh oh!
There was an error while loading. Please reload this page.
Mark repr128 as incomplete_features - #77488
Conversation
rust-highfive
commented
Oct 3, 2020
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
jonas-schievink
commented
Oct 11, 2020
@bors r+ |
bors
commented
Oct 11, 2020
📌 Commit db0438b has been approved by |
RalfJung
commented
Oct 12, 2020
With PRs like this, it is rather unfortunate that the stdlib sets |
varkor
commented
Oct 12, 2020
I believe so. It's possible some of the uses may only require |
… r=jonas-schievink Mark `repr128` as `incomplete_features` As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it. Closesrust-lang#77457.
… r=jonas-schievink Mark `repr128` as `incomplete_features` As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it. Closesrust-lang#77457.
JohnTitor
commented
Oct 12, 2020
Failed in https://github.com/rust-lang-ci/rust/runs/1243760569: Seems some tests on clippy also need a tweak. |
bors
commented
Oct 17, 2020
☔ The latest upstream changes (presumably #77124) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
db0438b to
683db31Comparevarkor
commented
Oct 22, 2020
@bors r=jonas-schievink |
bors
commented
Oct 22, 2020
📌 Commit 683db31 has been approved by |
… r=jonas-schievink Mark `repr128` as `incomplete_features` As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it. Closesrust-lang#77457.
Rollup of 17 pull requests Successful merges: - rust-lang#77268 (Link to "Contributing to Rust" rather than "Getting Started".) - rust-lang#77339 (Implement TryFrom between NonZero types.) - rust-lang#77488 (Mark `repr128` as `incomplete_features`) - rust-lang#77890 (Fixing escaping to ensure generation of welformed json.) - rust-lang#77918 (Cleanup network tests) - rust-lang#77920 (Avoid extraneous space between visibility kw and ident for statics) - rust-lang#77969 (Doc formating consistency between slice sort and sort_unstable, and big O notation consistency) - rust-lang#78098 (Clean up and improve some docs) - rust-lang#78116 (Make inline const work in range patterns) - rust-lang#78153 (Sync LLVM submodule if it has been initialized) - rust-lang#78163 (Clean up lib docs) - rust-lang#78169 (Update cargo) - rust-lang#78231 (Make closures inherit the parent function's target features) - rust-lang#78235 (Explain where the closure return type was inferred) - rust-lang#78255 (Reduce diagram mess in 'match arms have incompatible types' error) - rust-lang#78263 (Add regression test of issue-77668) - rust-lang#78265 (Add some inference-related regression tests about incorrect diagnostics) Failed merges: r? `@ghost`
As mentioned in #56071 and noticed in #77457,
repr(u128)andrepr(i128)do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.Closes#77457.