Skip to content

Mark repr128 as incomplete_features - #77488

Merged
bors merged 2 commits into
rust-lang:masterfrom
varkor:repr128-incomplete_features
Oct 23, 2020
Merged

Mark repr128 as incomplete_features#77488
bors merged 2 commits into
rust-lang:masterfrom
varkor:repr128-incomplete_features

Conversation

@varkor

@varkorvarkor commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

As mentioned in #56071 and noticed in #77457, repr(u128) and repr(i128) do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.

Closes#77457.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2020
@jonas-schievink

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit db0438b has been approved by jonas-schievink

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2020
@RalfJung

Copy link
Copy Markdown
Member

With PRs like this, it is rather unfortunate that the stdlib sets #![allow(incomplete_features)]... I suppose that's mostly due to const generics, so it'll be hard to do anything about this?

@varkor

Copy link
Copy Markdown
ContributorAuthor

I suppose that's mostly due to const generics, so it'll be hard to do anything about this?

I believe so. It's possible some of the uses may only require min_const_generics, which would avoid this problem. It could be worth trying to switch.

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 12, 2020
… r=jonas-schievink
Mark `repr128` as `incomplete_features`
As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.
Closesrust-lang#77457.
@JohnTitorJohnTitor mentioned this pull request Oct 12, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 12, 2020
… r=jonas-schievink
Mark `repr128` as `incomplete_features`
As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.
Closesrust-lang#77457.
@JohnTitorJohnTitor mentioned this pull request Oct 12, 2020
@JohnTitor

Copy link
Copy Markdown
Member

Failed in https://github.com/rust-lang-ci/rust/runs/1243760569:

---- compile_test stdout ----
thread 'compile_test' panicked at 'Some tests failed', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.5.0/src/lib.rs:105:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
compile_test
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '--test compile-test'
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/clippy/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--"
expected success, got: exit code: 101
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --stage 2 src/tools/clippy

Seems some tests on clippy also need a tweak.
@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2020
@bors

bors commented Oct 17, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #77124) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@varkor
varkorforce-pushed the repr128-incomplete_features branch from db0438b to 683db31CompareOctober 22, 2020 12:23
@varkor

Copy link
Copy Markdown
ContributorAuthor

@bors r=jonas-schievink

@bors

bors commented Oct 22, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 683db31 has been approved by jonas-schievink

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 22, 2020
… r=jonas-schievink
Mark `repr128` as `incomplete_features`
As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.
Closesrust-lang#77457.
@JohnTitorJohnTitor mentioned this pull request Oct 23, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2020
Rollup of 17 pull requests
Successful merges:
- rust-lang#77268 (Link to "Contributing to Rust" rather than "Getting Started".)
- rust-lang#77339 (Implement TryFrom between NonZero types.)
- rust-lang#77488 (Mark `repr128` as `incomplete_features`)
- rust-lang#77890 (Fixing escaping to ensure generation of welformed json.)
- rust-lang#77918 (Cleanup network tests)
- rust-lang#77920 (Avoid extraneous space between visibility kw and ident for statics)
- rust-lang#77969 (Doc formating consistency between slice sort and sort_unstable, and big O notation consistency)
- rust-lang#78098 (Clean up and improve some docs)
- rust-lang#78116 (Make inline const work in range patterns)
- rust-lang#78153 (Sync LLVM submodule if it has been initialized)
- rust-lang#78163 (Clean up lib docs)
- rust-lang#78169 (Update cargo)
- rust-lang#78231 (Make closures inherit the parent function's target features)
- rust-lang#78235 (Explain where the closure return type was inferred)
- rust-lang#78255 (Reduce diagram mess in 'match arms have incompatible types' error)
- rust-lang#78263 (Add regression test of issue-77668)
- rust-lang#78265 (Add some inference-related regression tests about incorrect diagnostics)
Failed merges:
r? `@ghost`
@bors
bors merged commit da3e41e into rust-lang:masterOct 23, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 23, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in nightly using repr(u128) with constant higher than is representable

8 participants

@varkor@rust-highfive@jonas-schievink@bors@RalfJung@JohnTitor@eddyb@rustbot