Skip to content

Only use Fira Sans for the first td in item lists - #77518

Merged
bors merged 1 commit into
rust-lang:masterfrom
camelid:rustdoc-use-correct-link-font
Oct 4, 2020
Merged

Only use Fira Sans for the first td in item lists#77518
bors merged 1 commit into
rust-lang:masterfrom
camelid:rustdoc-use-correct-link-font

Conversation

@camelid

Copy link
Copy Markdown
Member

Fixes#77516.

Fixes an issue where links in the one-line version of an item's docs
would be in Fira Sans, while the rest would be in a serifed font.

Fixes an issue where links in the one-line version of an item's docs
would be in Fira Sans, while the rest would be in a serifed font.
@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @jyn514

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2020
@camelidcamelid added C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 4, 2020
@jyn514

Copy link
Copy Markdown
Member

I am not the right reviewer for this.

r? @GuillaumeGomez
cc @Cldfire

@Cldfire

Copy link
Copy Markdown
Contributor

Wow, good eye! I never would have noticed that 😂

@camelid

Copy link
Copy Markdown
MemberAuthor

Before

image

After

image

@GuillaumeGomez

Copy link
Copy Markdown
Member

Looks good to me, thanks!

@bors: r+ rollup

@bors

bors commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit adfba2b has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2020
…as-schievink
Rollup of 8 pull requests
Successful merges:
- rust-lang#77072 (Minor `hash_map` doc adjustments + item attribute orderings)
- rust-lang#77368 (Backport LLVM apfloat commit to rustc_apfloat)
- rust-lang#77445 (BTreeMap: complete the compile-time test_variance test case)
- rust-lang#77504 (Support vectors with fewer than 8 elements for simd_select_bitmask)
- rust-lang#77513 (Change DocFragments from enum variant fields to structs with a nested enum)
- rust-lang#77518 (Only use Fira Sans for the first `td` in item lists)
- rust-lang#77521 (Move target feature whitelist from cg_llvm to cg_ssa)
- rust-lang#77525 (Enable RenameReturnPlace MIR optimization on mir-opt-level >= 2)
Failed merges:
r? `@ghost`
@bors
bors merged commit ec9b4d5 into rust-lang:masterOct 4, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 4, 2020
@camelid
camelid deleted the rustdoc-use-correct-link-font branch October 4, 2020 16:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bugCategory: This is a bug.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc: Links are styled as if they are Rust items

7 participants

@camelid@rust-highfive@jyn514@Cldfire@GuillaumeGomez@bors@rustbot