Uh oh!
There was an error while loading. Please reload this page.
rustc_target: Refactor away TargetResult - #77580
Merged
Merged
Conversation
Construction of a built-in target is always infallible now, so `TargetResult` is no longer necessary.
rust-highfive
commented
Oct 5, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
using the fact that it is infallible. JSON roundtrip check on every rustc run is also removed, it's already performed by unit tests.
matthewjasper
commented
Oct 9, 2020
Contributor
@bors r+ |
bors
commented
Oct 9, 2020
Collaborator
📌 Commit 1444ad7 has been approved by |
bors
commented
Oct 10, 2020
Collaborator
bors
commented
Oct 10, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #77202.
Construction of a built-in target is always infallible now, so
TargetResultis no longer necessary.The second commit contains some further cleanup based on built-in target construction being infallible.