Skip to content

Refactor IntErrorKind to avoid "underflow" terminology - #77640

Merged
bors merged 10 commits into
rust-lang:masterfrom
eopb:int_error_matching_attempt_2
Nov 9, 2020
Merged

Refactor IntErrorKind to avoid "underflow" terminology#77640
bors merged 10 commits into
rust-lang:masterfrom
eopb:int_error_matching_attempt_2

Conversation

@eopb

@eopbeopb commented Oct 7, 2020

Copy link
Copy Markdown
Contributor

This PR is a continuation of #76455

Changes

r? @KodrAus

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2020
@jonas-schievinkjonas-schievink added relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api [DEPRECATED; DO NOT USE] labels Oct 7, 2020
@eopbeopb mentioned this pull request Oct 11, 2020
Closed
KodrAus
KodrAus reviewed Oct 18, 2020
View reviewed changes

@KodrAusKodrAus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @ethanboxx! I've left a few little comments.

Since we're making some changes to the shape of the ParseIntError I think we should avoid stabilizing it just yet. Maybe give it a cycle or two with the new variants.

Comment threadcompiler/rustc_middle/src/middle/limits.rs Outdated
Comment threadlibrary/core/src/num/error.rs Outdated
Comment threadlibrary/core/src/num/error.rs Outdated
Comment threadlibrary/core/src/num/error.rs Outdated
Comment threadlibrary/core/src/num/error.rs Outdated
eopband others added 5 commits October 26, 2020 05:50
@eopb@KodrAus
Fix spelling eror
199c361
Co-authored-by: Ashley Mannix <kodraus@hey.com>
@eopb@KodrAus
Small reword
69c301f
Co-authored-by: Ashley Mannix <kodraus@hey.com>
@eopb@KodrAus
asci -> ASCII
75e6dee
Co-authored-by: Ashley Mannix <kodraus@hey.com>
@eopb
Apply suggested changes
ad2d93d
@eopb
Fix typo
e750238
@eopb

eopb commented Oct 26, 2020

Copy link
Copy Markdown
ContributorAuthor

@KodrAus Thank you for your review. This should be ready now.

@KodrAus

KodrAus commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @ethanboxx! This looks good to me.

@bors r+

@bors

bors commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit e750238 has been approved by KodrAus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2020
@KodrAusKodrAus changed the title stabilize int_error_matching attempt 2Refactor IntErrorKind to avoid "underflow" terminologyNov 6, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 8, 2020
@Dylan-DPC
Rollup merge ofrust-lang#77640- ethanboxx:int_error_matching_attemp…
a4d5d39
…t_2, r=KodrAus
Refactor IntErrorKind to avoid "underflow" terminology
This PR is a continuation of rust-lang#76455
# Changes
- `Overflow` renamed to `PosOverflow` and `Underflow` renamed to `NegOverflow` after discussion in rust-lang#76455
- Changed some of the parsing code to return `InvalidDigit` rather than `Empty` for strings "+" and "-". https://users.rust-lang.org/t/misleading-error-in-str-parse-for-int-types/49178
- Carry the problem `char` with the `InvalidDigit` variant.
- Necessary changes were made to the compiler as it depends on `int_error_matching`.
- Redid tests to match on specific errors.
r? `@KodrAus`
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Nov 8, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 8, 2020
@Dylan-DPC
Rollup merge ofrust-lang#77640- ethanboxx:int_error_matching_attemp…
a2c2720
…t_2, r=KodrAus
Refactor IntErrorKind to avoid "underflow" terminology
This PR is a continuation of rust-lang#76455
# Changes
- `Overflow` renamed to `PosOverflow` and `Underflow` renamed to `NegOverflow` after discussion in rust-lang#76455
- Changed some of the parsing code to return `InvalidDigit` rather than `Empty` for strings "+" and "-". https://users.rust-lang.org/t/misleading-error-in-str-parse-for-int-types/49178
- Carry the problem `char` with the `InvalidDigit` variant.
- Necessary changes were made to the compiler as it depends on `int_error_matching`.
- Redid tests to match on specific errors.
r? ``@KodrAus``
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Nov 8, 2020
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Nov 9, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 9, 2020
@bors
Auto merge ofrust-lang#78889- Dylan-DPC:rollup-6zjhahf, r=Dylan-DPC
fe8f026
Rollup of 12 pull requests
Successful merges:
- rust-lang#77640 (Refactor IntErrorKind to avoid "underflow" terminology)
- rust-lang#78026 (Define `fs::hard_link` to not follow symlinks.)
- rust-lang#78114 (Recognize `private_intra_doc_links` as a lint)
- rust-lang#78228 (Promote aarch64-unknown-linux-gnu to Tier 1)
- rust-lang#78345 (Fix handling of item names for HIR)
- rust-lang#78437 (BTreeMap: stop mistaking node for an orderly place)
- rust-lang#78476 (fix some incorrect aliasing in the BTree)
- rust-lang#78674 (inliner: Use substs_for_mir_body)
- rust-lang#78748 (Implement destructuring assignment for tuples)
- rust-lang#78868 (Fix tab focus on restyled switches)
- rust-lang#78878 (Avoid overlapping cfg attributes when both macOS and aarch64)
- rust-lang#78882 (Nicer hunk headers for rust files)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d69ee57 into rust-lang:masterNov 9, 2020
@rustbotrustbot added this to the 1.49.0 milestone Nov 9, 2020
@eopb
eopb deleted the int_error_matching_attempt_2 branch December 7, 2020 12:03
@kennytmkennytm mentioned this pull request May 4, 2021
Closed
@eopbeopb mentioned this pull request May 4, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2021
@bors
Auto merge ofrust-lang#84910- eopb:stabilize_int_error_matching, r=…
75ed342
…yaahc
stabilize `int_error_matching`
closesrust-lang#22639
> It has been over half a year since rust-lang#77640 (review), and the indexing question is rejected in rust-lang#79728 (review), so I guess we can submit another stabilization attempt? 😉
_Originally posted by `@kennytm` in rust-lang#22639 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KodrAusKodrAusKodrAus left review comments

Assignees

@KodrAusKodrAus

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

6 participants

@eopb@KodrAus@bors@jonas-schievink@rust-highfive@rustbot