Skip to content

Remove unnecessary lamda on emitter map. - #77673

Merged
bors merged 2 commits into
rust-lang:masterfrom
heckad:patch-2
Oct 9, 2020
Merged

Remove unnecessary lamda on emitter map.#77673
bors merged 2 commits into
rust-lang:masterfrom
heckad:patch-2

Conversation

@heckad

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2020
Comment threadcompiler/rustc_driver/src/lib.rs Outdated
@lcnr

lcnr commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Thanks, do you mind implementing the suggestion by @jonas-schievink? Afterwards this can be merged

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@lcnr

lcnr commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 8, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit dd60ab3 has been approved by lcnr

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2020
@lcnrlcnr mentioned this pull request Oct 8, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 8, 2020
Remove unnecessary lamda on emitter map.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 8, 2020
…as-schievink
Rollup of 8 pull requests
Successful merges:
- rust-lang#76750 (Don't discourage implementing `core::fmt::Write`)
- rust-lang#77449 (BTreeMap: comment why drain_filter's size_hint is somewhat pessimistic)
- rust-lang#77660 ((docs): make mutex error comment consistent with codebase)
- rust-lang#77663 (Add compile fail test for issue 27675)
- rust-lang#77673 (Remove unnecessary lamda on emitter map.)
- rust-lang#77701 (Make `max_log_info` easily greppable (for figuring out why debug logging is disabled))
- rust-lang#77702 (Remove not needed lambda.)
- rust-lang#77710 (Update submodule llvm to get LVI bugfix)
Failed merges:
r? `@ghost`
@bors
bors merged commit 48c1ca1 into rust-lang:masterOct 9, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 9, 2020
@heckad
heckad deleted the patch-2 branch October 9, 2020 14:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@heckad@rust-highfive@lcnr@bors@jonas-schievink@rustbot