Skip to content

Unset GIT_DIR in pre-commit hook - #77683

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:git-hook
Oct 8, 2020
Merged

Unset GIT_DIR in pre-commit hook#77683
bors merged 1 commit into
rust-lang:masterfrom
jyn514:git-hook

Conversation

@jyn514

Copy link
Copy Markdown
Member

Works around #77620. This won't help any other hooks you write manually, but hopefully people won't feel the need to do that now there's an 'official' one.

r? @Mark-Simulacrum
cc @caass

@jyn514jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust labels Oct 7, 2020
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2020
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

Okay, seems fine.

@bors

bors commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f498949 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2020
@caass

caass commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

@jyn514 awesome ty for fixing this!

@bors

bors commented Oct 8, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f498949 with merge cc662cd...

@bors

bors commented Oct 8, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing cc662cd to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 8, 2020
@bors
bors merged commit cc662cd into rust-lang:masterOct 8, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to Rustmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jyn514@Mark-Simulacrum@bors@caass@rust-highfive@rustbot