Uh oh!
There was an error while loading. Please reload this page.
liballoc: VecDeque: Add binary search functions - #77751
Merged
Merged
Conversation
rust-highfive
commented
Oct 9, 2020
Contributor
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
vojtechkralforce-pushed
the
vecdeque-binary-search
branch
from
October 9, 2020 14:08
d2bb567 to
a4b160eComparevojtechkralforce-pushed
the
vecdeque-binary-search
branch
from
October 9, 2020 18:53
a4b160e to
36d9b72Comparedtolnay
approved these changes
Oct 15, 2020
dtolnay
left a comment
Member
There was a problem hiding this comment.
Thanks, this is great.
Please make a tracking issue and update the stability attributes in the PR.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
5 tasks
vojtechkralforce-pushed
the
vecdeque-binary-search
branch
from
October 16, 2020 18:51
8659a11 to
c7a787aComparevojtechkral
commented
Oct 16, 2020
ContributorAuthor
Added a tracking issue, simplified implementation as suggested by @scottmcm ... |
scottmcm
commented
Oct 16, 2020
Member
Stability attributes and code updates look good to me; thanks! @bors r=scottmcm,dtolnay (Feel free to |
bors
commented
Oct 16, 2020
Collaborator
📌 Commit c7a787a has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Oct 17, 2020
… r=scottmcm,dtolnay liballoc: VecDeque: Add binary search functions I am submitting rust-lang/rfcs#2997 as a PR as suggested by @scottmcm I haven't yet created a tracking issue - if there's a favorable feedback I'll create one and update the issue links in the unstable attribs.
This was referenced Oct 17, 2020
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#76199 (Permit uninhabited enums to cast into ints) - rust-lang#77751 (liballoc: VecDeque: Add binary search functions) - rust-lang#77785 (Remove compiler-synthesized reexports when documenting) - rust-lang#77932 (BTreeMap: improve gdb introspection of BTreeMap with ZST keys or values) - rust-lang#77961 (Set .llvmbc and .llvmcmd sections as allocatable) - rust-lang#77985 (llvm: backport SystemZ fix for AGR clobbers) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am submitting rust-lang/rfcs#2997 as a PR as suggested by @scottmcm
I haven't yet created a tracking issue - if there's a favorable feedback I'll create one and update the issue links in the unstable attribs.Tracking issue: #78021