Uh oh!
There was an error while loading. Please reload this page.
Suggest minimal subset features in incomplete_features lint - #77925
Merged
Conversation
rust-highfive
commented
Oct 13, 2020
Contributor
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
davidtwco
approved these changes
Oct 14, 2020
davidtwco
left a comment
Member
There was a problem hiding this comment.
LGTM, I like this change but I'm slightly unsure on the exact wording (cc @rust-lang/wg-diagnostics). r=me after a little bikeshedding.
Uh oh!
There was an error while loading. Please reload this page.
JohnTitorforce-pushed
the
sugg-min-features
branch
from
October 16, 2020 17:01
db7c461 to
f7150beCompareJohnTitor
commented
Oct 16, 2020
MemberAuthor
bors
commented
Oct 16, 2020
Collaborator
📌 Commit f7150be has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 16, 2020
…dtwco,oli-obk Suggest minimal subset features in `incomplete_features` lint This tells users that we have a minimal subset feature of it and they can fix the lint warning without allowing it. The wording improvement is helpful :) Fixesrust-lang#77913
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#75209 (Suggest imports of unresolved macros) - rust-lang#77547 (stabilize union with 'ManuallyDrop' fields and 'impl Drop for Union') - rust-lang#77827 (Don't link to nightly primitives on stable channel) - rust-lang#77855 (resolve: further improvements to "try using the enum's variant" diagnostic) - rust-lang#77900 (Use fdatasync for File::sync_data on more OSes) - rust-lang#77925 (Suggest minimal subset features in `incomplete_features` lint) - rust-lang#77971 (Deny broken intra-doc links in linkchecker) - rust-lang#77991 (Bump backtrace-rs) - rust-lang#77992 (instrument-coverage: try our best to not ICE) - rust-lang#78013 (Fix sidebar scroll on mobile devices) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tells users that we have a minimal subset feature of it and they can fix the lint warning without allowing it.
The wording improvement is helpful :)
Fixes#77913