Skip to content

Add support for SHA256 source file hashing - #77950

Merged
bors merged 1 commit into
rust-lang:masterfrom
arlosi:sha256
Nov 3, 2020
Merged

Add support for SHA256 source file hashing#77950
bors merged 1 commit into
rust-lang:masterfrom
arlosi:sha256

Conversation

@arlosi

Copy link
Copy Markdown
Contributor

Adds support for -Z src-hash-algorithm sha256, which became available in LLVM 11.

Using an older version of LLVM will cause an error invalid checksum kind if the hash algorithm is set to sha256.

r? @eddyb
cc #70401@est31

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2020
@arlosi

This comment has been minimized.

@arlosi

Copy link
Copy Markdown
ContributorAuthor

Adding // min-llvm-version: 11.0 to the test.

@eddyb

eddyb commented Nov 1, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 1, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 3296d5c has been approved by eddyb

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2020
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 1, 2020
Add support for SHA256 source file hashing
Adds support for `-Z src-hash-algorithm sha256`, which became available in LLVM 11.
Using an older version of LLVM will cause an error `invalid checksum kind` if the hash algorithm is set to sha256.
r? @eddyb
cc rust-lang#70401@est31
@m-ou-sem-ou-se mentioned this pull request Nov 1, 2020
@bors

bors commented Nov 1, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3296d5c with merge 6010a9cd203b4934db12548a05b4773ff64ce3ca...

@bors

bors commented Nov 1, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 1, 2020
@arlosi

Copy link
Copy Markdown
ContributorAuthor

The failure doesn't look related to this change. Can someone retry?

@est31

est31 commented Nov 3, 2020

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2020
@m-ou-sem-ou-se mentioned this pull request Nov 3, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2020
Rollup of 7 pull requests
Successful merges:
- rust-lang#77950 (Add support for SHA256 source file hashing)
- rust-lang#78624 (Sync rustc_codegen_cranelift)
- rust-lang#78626 (Improve errors about #[deprecated] attribute)
- rust-lang#78659 (Corrected suggestion for generic parameters in `function_item_references` lint)
- rust-lang#78687 (Suggest library/std when running all stage 0 tests)
- rust-lang#78699 (Show more error information in lldb_batchmode)
- rust-lang#78709 (Fix panic in bootstrap for non-workspace path dependencies.)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 52405f7 into rust-lang:masterNov 3, 2020
@rustbotrustbot added this to the 1.49.0 milestone Nov 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@arlosi@eddyb@bors@est31@rust-highfive@rustbot