Skip to content

MIR validation should check SwitchInt values are valid for the type - #78085

Merged
bors merged 1 commit into
rust-lang:masterfrom
wesleywiser:mir_validation_switch_int
Oct 25, 2020
Merged

MIR validation should check SwitchInt values are valid for the type#78085
bors merged 1 commit into
rust-lang:masterfrom
wesleywiser:mir_validation_switch_int

Conversation

@wesleywiser

Copy link
Copy Markdown
Member

Fixes#75440

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2020

@oli-obkoli-obk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit

Comment threadcompiler/rustc_mir/src/transform/validate.rs Outdated
Comment threadcompiler/rustc_mir/src/transform/validate.rs Outdated
@oli-obk

Copy link
Copy Markdown
Contributor

@bors rollup

@wesleywiser
wesleywiserforce-pushed the mir_validation_switch_int branch from 1a5c915 to dd683e5CompareOctober 24, 2020 20:02
@wesleywiser

Copy link
Copy Markdown
MemberAuthor

@bors r=oli-obk

@bors

bors commented Oct 24, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit dd683e5 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2020
@JohnTitorJohnTitor mentioned this pull request Oct 25, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2020
Rollup of 8 pull requests
Successful merges:
- rust-lang#77984 (Compute proper module parent during resolution)
- rust-lang#78085 (MIR validation should check `SwitchInt` values are valid for the type)
- rust-lang#78208 (replace `#[allow_internal_unstable]` with `#[rustc_allow_const_fn_unstable]` for `const fn`s)
- rust-lang#78209 (Update `compiler_builtins` to 0.1.36)
- rust-lang#78276 (Bump backtrace-rs to enable Mach-O support on iOS.)
- rust-lang#78320 (Link to cargo's `build-std` feature instead of `xargo` in custom target docs)
- rust-lang#78322 (BTreeMap: stop mistaking node::MIN_LEN for a node level constraint)
- rust-lang#78326 (Split out statement attributes changes from rust-lang#78306)
Failed merges:
r? `@ghost`
@bors
bors merged commit dbdc61f into rust-lang:masterOct 25, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-Zvalidate-mir should check that SwitchInt values are valid for their type

5 participants

@wesleywiser@rust-highfive@oli-obk@bors@rustbot