Skip to content

Separate unsized locals - #78152

Merged
bors merged 22 commits into
rust-lang:masterfrom
spastorino:separate-unsized-locals
Oct 28, 2020
Merged

Separate unsized locals#78152
bors merged 22 commits into
rust-lang:masterfrom
spastorino:separate-unsized-locals

Conversation

@spastorino

@spastorinospastorino commented Oct 20, 2020

Copy link
Copy Markdown
Member

Closes#71694

Takes over again #72029 and #74971

cc @RalfJung@oli-obk@pnkfelix@eddyb as they've participated in previous reviews of this PR.

@rust-highfive

rust-highfive commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2020
@spastorino
spastorinoforce-pushed the separate-unsized-locals branch from 927b11a to d3a17afCompareOctober 20, 2020 20:26
eddyb
eddyb reviewed Oct 20, 2020
View reviewed changes
Comment threadcompiler/rustc_typeck/src/check/gather_locals.rs Outdated
@eddyb

eddyb commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

r? @pnkfelix (as per #72029 and #74971)

@rust-highfiverust-highfive assigned pnkfelix and unassigned eddybOct 20, 2020
RalfJung
RalfJung reviewed Oct 20, 2020
View reviewed changes
Comment threadcompiler/rustc_mir/src/borrow_check/type_check/mod.rs Outdated
RalfJung
RalfJung reviewed Oct 20, 2020
View reviewed changes
Comment threadcompiler/rustc_typeck/src/check/gather_locals.rs Outdated
RalfJung
RalfJung reviewed Oct 20, 2020
View reviewed changes
Comment threadsrc/test/ui/unsized-locals/unsized-local-pat.rs Outdated
RalfJung
RalfJung reviewed Oct 20, 2020
View reviewed changes
Comment threadsrc/test/ui/unsized-locals/unsized-locals-using-unsized-fn-params.rs Outdated
@spastorino

spastorino commented Oct 21, 2020

Copy link
Copy Markdown
MemberAuthor

@RalfJung have addressed all your comments, let me know if there's something else to fix.

RalfJung
RalfJung reviewed Oct 21, 2020
View reviewed changes
Comment threadcompiler/rustc_mir/src/borrow_check/type_check/mod.rs Outdated
RalfJung
RalfJung reviewed Oct 21, 2020
View reviewed changes
Comment threadcompiler/rustc_mir/src/borrow_check/type_check/mod.rs Outdated
@spastorino

spastorino commented Oct 21, 2020

Copy link
Copy Markdown
MemberAuthor

@RalfJung all your new comments are addressed

RalfJung
RalfJung reviewed Oct 21, 2020
View reviewed changes
Comment threadcompiler/rustc_mir/src/borrow_check/type_check/mod.rs Outdated
@spastorino
spastorinoforce-pushed the separate-unsized-locals branch 2 times, most recently from 7566c3d to 61d9745CompareOctober 21, 2020 11:09
RalfJung
RalfJung reviewed Oct 21, 2020
View reviewed changes
Comment threadsrc/test/ui/unsized-locals/unsized-locals-using-unsized-fn-params.rs Outdated
@RalfJung

RalfJung commented Oct 21, 2020

Copy link
Copy Markdown
Member

LGTM except for that question around the tests.

However, I cannot review the analysis changes here, I have no familiarity with that code. Hopefully @pnkfelix can take care of that. :)

RalfJung
RalfJung reviewed Oct 21, 2020
View reviewed changes
Comment threadsrc/test/ui/unsized-locals/unsized-local-pat.rs Outdated
@spastorino
spastorinoforce-pushed the separate-unsized-locals branch from 685a795 to 397777bCompareOctober 21, 2020 11:56
@spastorino
spastorinoforce-pushed the separate-unsized-locals branch from 397777b to cc9ab1cCompareOctober 27, 2020 17:46
@spastorino

spastorino commented Oct 27, 2020

Copy link
Copy Markdown
MemberAuthor

Rebased again to solve conflicts.

@oli-obk

oli-obk commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

I think Felix has his hands full this week. I went over the code one more time, can't see any reason not to merge now

@bors r+

@bors

bors commented Oct 27, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit cc9ab1c has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Oct 28, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2020
@bors
Auto merge ofrust-lang#78458- Dylan-DPC:rollup-tan044s, r=Dylan-DPC
db241bb
Rollup of 10 pull requests
Successful merges:
- rust-lang#78152 (Separate unsized locals)
- rust-lang#78297 (Suggest calling await on method call and field access)
- rust-lang#78351 (Move "mutable thing in const" check from interning to validity)
- rust-lang#78365 (check object safety of generic constants)
- rust-lang#78379 (Tweak invalid `fn` header and body parsing)
- rust-lang#78391 (Add const_fn in generics test)
- rust-lang#78401 (resolve: private fields in tuple struct ctor diag)
- rust-lang#78408 (Remove tokens from foreign items in `TokenStripper`)
- rust-lang#78447 (Fix typo in comment)
- rust-lang#78453 (Fix typo in comments)
Failed merges:
r? `@ghost`
@bors
bors merged commit 346aeef into rust-lang:masterOct 28, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 28, 2020
JohnTitor added a commit to JohnTitor/glacier that referenced this pull request Oct 29, 2020
@JohnTitor
Address the changes byrust-lang/rust#78152
a57d066
Alexendoo added a commit to rust-lang/glacier that referenced this pull request Oct 29, 2020
@Alexendoo
Merge pull request#528from JohnTitor/unsized-fn-params
9abf63d
Address the changes by rust-lang/rust#78152
@huitseekerhuitseeker mentioned this pull request Oct 30, 2020
Closed
@hellow554hellow554 mentioned this pull request Apr 28, 2021
Closed
@RalfJungRalfJung mentioned this pull request May 4, 2023
Open
@matthiaskrgrmatthiaskrgr mentioned this pull request Apr 13, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments
+1 more reviewer
@eddybeddybeddyb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pnkfelixpnkfelix

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

Separate unsized_locals into "sound" and "unsound" (i.e. incorrectly implemented) parts

8 participants

@spastorino@rust-highfive@eddyb@RalfJung@oli-obk@bors@pnkfelix@rustbot