Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #78158
Closed
GuillaumeGomez wants to merge 21 commits into
Closed
Conversation
Interning can skip any inhabited ZST type in general.
Now refers to `wrapping_*`, not `checked_*` for wrapping intrinsics.
These parameters don't get modified.
Add codegen test for issue rust-lang#73827Closesrust-lang#73827
…, r=oli-obk Optimize const value interning for ZST types Interning can skip any inhabited ZST type in general. Fixesrust-lang#68010 r? @oli-obk
we can test std and core panic macros together r? @oli-obk
Move orphan module-name/mod.rs files into module-name.rs files
Wrapping intrinsics doc links update. The links in the wrapping intrinsics docs now refer to the `wrapping_*` functions, not the `checked_*` functions.
Add some MIR-related regression tests Closesrust-lang#68841Closesrust-lang#75053Closesrust-lang#76375Closesrust-lang#77911 I think they're fixed by rust-lang#77306.
Don't update `entries` in `TypedArena` if T does not need drop As far as I can tell, `entries` is only used when dropping `TypedArenaChunk`s and their contents. It is already ignored there, if T is not `mem::needs_drop`, this PR just skips updating it's value. You can see `TypedArenaChunk` ignoring the entry count in L71. The reasoning is similar to what you can find in `DroplessArena`. r? @oli-obk
…ievink Drop unneeded `mut` These parameters don't get modified. Note that `trailing_comment` is pub and gets exported from `rustc_ast_pretty`. Is that considered to be a stable API? If yes, and you want to reserve the right to modify `self` in `trailing_comment` in the future, that hunk would need to be dropped.
…r=jyn514 Remove unused type from librustdoc r? @jyn514
GuillaumeGomez
commented
Oct 20, 2020
MemberAuthor
@bors: r+ p=9 |
bors
commented
Oct 20, 2020
Collaborator
📌 Commit 8ac8b56 has been approved by |
GuillaumeGomez
commented
Oct 20, 2020
MemberAuthor
@bors: r- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
entriesinTypedArenaif T does not need drop #78144 (Don't updateentriesinTypedArenaif T does not need drop)mut#78145 (Drop unneededmut)Failed merges:
r? @ghost