Uh oh!
There was an error while loading. Please reload this page.
const_evaluatable_checked: deal with unused nodes + div - #78272
Merged
Conversation
oli-obk
reviewed
Oct 23, 2020
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
reviewed
Oct 23, 2020
| self.error(None, "unused node")?; | ||
| } | ||
| return Ok(self |
Contributor
There was a problem hiding this comment.
if you use a separate map for metadata not needed for the result, you can use alloc_slice which is cheaper than alloc_from_iter (though that will probably need a method to get a slice from an IndexVec, too)
ContributorAuthor
There was a problem hiding this comment.
I don't think perf is too important here and prefer to prevent accidents where we forget to update one of the vecs, will add spans though
oli-obk
reviewed
Oct 23, 2020
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
reviewed
Oct 23, 2020
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
commented
Oct 23, 2020
Contributor
@bors r+ |
bors
commented
Oct 23, 2020
Collaborator
📌 Commit 47cb871 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 24, 2020
…as-schievink Rollup of 12 pull requests Successful merges: - rust-lang#75115 (`#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi) - rust-lang#76614 (change the order of type arguments on ControlFlow) - rust-lang#77610 (revise Hermit's mutex interface to support the behaviour of StaticMutex) - rust-lang#77830 (Simplify query proc-macros) - rust-lang#77930 (Do not ICE with TraitPredicates containing [type error]) - rust-lang#78069 (Fix const core::panic!(non_literal_str).) - rust-lang#78072 (Cleanup constant matching in exhaustiveness checking) - rust-lang#78119 (Throw core::panic!("message") as &str instead of String.) - rust-lang#78191 (Introduce a temporary for discriminant value in MatchBranchSimplification) - rust-lang#78272 (const_evaluatable_checked: deal with unused nodes + div) - rust-lang#78318 (TyCtxt: generate single impl block with `slice_interners` macro) - rust-lang#78327 (resolve: Relax macro resolution consistency check to account for any errors) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @oli-obk