Skip to content

Make some functions private that don't have to be public - #78348

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:pub-crate
Oct 27, 2020
Merged

Make some functions private that don't have to be public#78348
bors merged 1 commit into
rust-lang:masterfrom
jyn514:pub-crate

Conversation

@jyn514

Copy link
Copy Markdown
Member

@jyn514jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 25, 2020
@rust-highfive

This comment has been minimized.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2020
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Oct 25, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit e218380 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 25, 2020
Make some functions private that don't have to be public
r? @GuillaumeGomez
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 25, 2020
Make some functions private that don't have to be public
r? @GuillaumeGomez
@JohnTitorJohnTitor mentioned this pull request Oct 26, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2020
Rollup of 16 pull requests
Successful merges:
- rust-lang#76635 (Add [T]::as_chunks(_mut))
- rust-lang#77703 (add system-llvm-libunwind config option)
- rust-lang#78219 (Prefer to use `print_def_path`)
- rust-lang#78298 (Add test for bad NLL higher-ranked subtype)
- rust-lang#78332 (Update description for error E0308)
- rust-lang#78342 (Use check-pass in single-use-lifetime ui tests)
- rust-lang#78347 (Add lexicographical comparison doc)
- rust-lang#78348 (Make some functions private that don't have to be public)
- rust-lang#78349 (Use its own `TypeckResults` to avoid ICE)
- rust-lang#78375 (Use ? in core/std macros)
- rust-lang#78377 (Fix typo in debug statement)
- rust-lang#78388 (Add some regression tests)
- rust-lang#78394 (fix(docs): typo in BufWriter documentation)
- rust-lang#78396 (Add compiler support for LLVM's x86_64 ERMSB feature)
- rust-lang#78405 (Fix typo in lint description)
- rust-lang#78412 (Improve formatting of hash collections docs)
Failed merges:
r? `@ghost`
@bors
bors merged commit ae54425 into rust-lang:masterOct 27, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 27, 2020
@jyn514
jyn514 deleted the pub-crate branch November 7, 2020 18:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jyn514@rust-highfive@GuillaumeGomez@bors@rustbot