Uh oh!
There was an error while loading. Please reload this page.
Add type to ConstKind::Placeholder - #78463
Merged
Merged
Conversation
varkor
marked this pull request as draft
October 28, 2020 01:19
varkorforce-pushed
the
placeholder-const
branch
from
October 28, 2020 02:08
e7fd4fe to
eb40907Comparevarkor
commented
Oct 28, 2020
Uh oh!
There was an error while loading. Please reload this page.
varkor
marked this pull request as ready for review
October 28, 2020 02:25
lcnr
reviewed
Oct 28, 2020
Uh oh!
There was an error while loading. Please reload this page.
varkorforce-pushed
the
placeholder-const
branch
from
October 28, 2020 10:38
eb40907 to
8014f1eCompareUh oh!
There was an error while loading. Please reload this page.
varkorforce-pushed
the
placeholder-const
branch
from
November 10, 2020 00:11
8014f1e to
ba4bb90Comparenikomatsakis
requested changes
Nov 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
varkorforce-pushed
the
placeholder-const
branch
from
November 12, 2020 15:40
ba4bb90 to
e24a4b4Comparenikomatsakis
commented
Nov 12, 2020
Contributor
@bors r+ |
bors
commented
Nov 12, 2020
Collaborator
📌 Commit e24a4b4 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2020
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#77151 (Add regression test for issue rust-lang#76042) - rust-lang#77996 (Doc change: Remove mention of `fnv` in HashMap) - rust-lang#78463 (Add type to `ConstKind::Placeholder`) - rust-lang#78984 (Rustdoc check option) - rust-lang#78985 (add dropck test for const params) - rust-lang#78996 (add explicit test for const param promotion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simply threaded
<'tcx>through everything that required it. I'm not sure whether this is the correct thing to do, but it seems to work.r? @nikomatsakis