Skip to content

Updated release notes. - #78690

Closed
avr1254 wants to merge 6 commits into
rust-lang:masterfrom
avr1254:release-update
Closed

Updated release notes.#78690
avr1254 wants to merge 6 commits into
rust-lang:masterfrom
avr1254:release-update

Conversation

@avr1254

@avr1254avr1254 commented Nov 3, 2020•
edited by JohnTitor
Loading

Copy link
Copy Markdown

They now mention the allowing of attribute procedural macros to a module. Resolves#77098

@rust-highfive

rust-highfive commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2020
@jyn514jyn514 added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Nov 3, 2020
JohnTitor
JohnTitor reviewed Nov 3, 2020
View reviewed changes
Comment threadRELEASES.md Outdated
ehuss
ehuss reviewed Nov 3, 2020
View reviewed changes
Comment threadRELEASES.md Outdated
@avr1254@ehuss
Update RELEASES.md to include better linguistic semantics
1cf5f6e
Co-authored-by: Eric Huss <eric@huss.org>
@Mark-Simulacrum

Mark-Simulacrum commented Nov 6, 2020

Copy link
Copy Markdown
Member

r=me with commits squashed

@Mark-SimulacrumMark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2020
@avr1254avr1254 closed this Nov 7, 2020
@avr1254
avr1254 deleted the release-update branch November 7, 2020 00:15
@EmounEmoun mentioned this pull request Apr 29, 2021
Closed
@0xPoe0xPoe mentioned this pull request Jun 18, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2021
@JohnTitor
Rollup merge ofrust-lang#86427- hi-rustin:rustin-patch-release-note…
4a54179
…, r=Mark-Simulacrum
Updated release note
closerust-lang#77098
base on rust-lang#78690
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2021
@JohnTitor
Rollup merge ofrust-lang#86427- hi-rustin:rustin-patch-release-note…
13b0f1a
…, r=Mark-Simulacrum
Updated release note
closerust-lang#77098
base on rust-lang#78690
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor left review comments
+1 more reviewer
@ehussehussehuss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rust/RELEASES.md doesn't mention that 1.42 allows custom attributes on modules

6 participants

@avr1254@rust-highfive@Mark-Simulacrum@ehuss@JohnTitor@jyn514