Uh oh!
There was an error while loading. Please reload this page.
Rollup of 12 pull requests - #78804
Closed
JohnTitor wants to merge 30 commits into
Closed
Conversation
This reverts commit 7cae9e8.
This undocumented feature allows you to typo 'a' as '1'.
Inliner copies the unevaluated constants from the callee body to the caller at the point where decision to inline is yet to be made. The constants will be unnecessary if inlining were to fail. Organize the code moving items from callee to the caller together in one place to avoid the issue.
Originally, there has been a dedicated pass for renumbering AST NodeIds to have actual values. This pass had been added by commit a5ad4c3. Then, later, this step was moved to where it resides now, macro expansion. See commit c86c8d4 or PR rust-lang#36438. The comment snippet, added by the original commit, has survived the times without any change, becoming outdated at removal of the dedicated pass. Nowadays, grepping for the next_node_id function will show up multiple places in the compiler that call it, but the main rewriting that the comment talks about is still done in the expansion step, inside an innocious looking visit_id function that's called during macro invocation collection.
`#![deny(unsafe_op_in_unsafe_fn)]` in sys/hermit Partial fix of rust-lang#73904. This encloses ``unsafe`` operations in ``unsafe fn`` in ``sys/hermit``. Some unsafe blocks are not well documented because some system-based functions lack documents.
Use Intra-doc links for std::io::buffered Helps with rust-lang#75080. I used the implicit link style for intrinsics, as that was what `minnumf32` and others already had. `@rustbot` modify labels: T-doc, A-intra-doc-links r? `@jyn514`
Fix unreachable sub-branch detection in or-patterns The previous implementation was too eager to avoid unnecessary "unreachable pattern" warnings. I feel more confident about this implementation than I felt about the previous one. Fixesrust-lang#76836. `@rustbot` modify labels: +A-exhaustiveness-checking
Allow using 1/2/3/4 for `x.py setup` options This undocumented feature allows you to typo 'a' as '1'. r? ``@Mark-Simulacrum`` cc ``@Lokathor``
…imulacrum BTreeMap: document a curious assumption in test cases r? ``@Mark-Simulacrum``
…lacrum Add LLVM upgrades from 7 to 10 to RELEASES.md Fixesrust-lang#78464
Expand explanation of reverse_bits Original documentation only rephrased the function name
…uillaumeGomez `deny(invalid_codeblock_attributes)` for rustc_error_codes Closesrust-lang#71478. r? `@GuillaumeGomez`
inliner: Copy unevaluated constants only after successful inlining Inliner copies the unevaluated constants from the callee body to the caller at the point where decision to inline is yet to be made. The constants will be unnecessary if inlining were to fail. Organize the code moving items from callee to the caller together in one place to avoid the issue.
rustc_expand: use collect_bang helper instead of manual reimplementation
…=oli-obk The renumber pass is long gone Originally, there has been a dedicated pass for renumbering AST NodeIds to have actual values. This pass had been added by commit a5ad4c3. Then, later, this step was moved to where it resides now, macro expansion. See commit c86c8d4 or PR rust-lang#36438. The comment snippet, added by the original commit, has survived the times without any change, becoming outdated at removal of the dedicated pass. Nowadays, grepping for the next_node_id function will show up multiple places in the compiler that call it, but the main rewriting that the comment talks about is still done in the expansion step, inside an innocious looking visit_id function that's called during macro invocation collection.
…-schievink Fixing Spelling Typos Fixing rust-lang#78787
JohnTitor
commented
Nov 6, 2020
MemberAuthor
@bors r+ p=5 rollup=never |
bors
commented
Nov 6, 2020
Collaborator
📌 Commit b7e8bef has been approved by |
bors
commented
Nov 6, 2020
Collaborator
⌛ Testing commit b7e8bef with merge eba8a63c76ac0621e6446f0550b3590dcc6bb673... |
bors
commented
Nov 6, 2020
Collaborator
💔 Test failed - checks-actions |
JohnTitor
commented
Nov 6, 2020
MemberAuthor
@bors retry |
bors
commented
Nov 6, 2020
Collaborator
⌛ Testing commit b7e8bef with merge af49714761259622034da1251be510552262aea0... |
bors
commented
Nov 6, 2020
Collaborator
💔 Test failed - checks-actions |
JohnTitor
commented
Nov 6, 2020
MemberAuthor
Ugh, it happens again, let's re-create rollup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#![deny(unsafe_op_in_unsafe_fn)]in sys/hermit #74979 (#![deny(unsafe_op_in_unsafe_fn)]in sys/hermit)x.py setupoptions #78514 (Allow using 1/2/3/4 forx.py setupoptions)deny(invalid_codeblock_attributes)for rustc_error_codes #78760 (deny(invalid_codeblock_attributes)for rustc_error_codes)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup