Uh oh!
There was an error while loading. Please reload this page.
Explicitly checking for or-pattern before test - #78856
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
8 tasks
mark-i-m
commented
Nov 7, 2020
ContributorAuthor
mark-i-mforce-pushed
the
fix-or-pat-ice
branch
3 times, most recently
from
November 8, 2020 05:00
a656efb to
db463c6Comparemark-i-m
commented
Nov 8, 2020
ContributorAuthor
Looks ready for review :) |
varkor
reviewed
Nov 8, 2020
varkor
left a comment
Contributor
There was a problem hiding this comment.
It's been a while since I dealt with this code, so I'd rather @matthewjasper took a look.
Uh oh!
There was an error while loading. Please reload this page.
varkor
commented
Nov 8, 2020
Contributor
Uh oh!
There was an error while loading. Please reload this page.
matthewjasper
left a comment
Contributor
There was a problem hiding this comment.
One style nit that would be nice to have fixed before this is merged
Uh oh!
There was an error while loading. Please reload this page.
matthewjasper
commented
Nov 14, 2020
Contributor
@bors r+ |
bors
commented
Nov 14, 2020
Collaborator
📌 Commit 43e4783 has been approved by |
mark-i-m
commented
Nov 14, 2020
ContributorAuthor
@matthewjasper Nit addressed :) Good catch! |
matthewjasper
commented
Nov 14, 2020
Contributor
@bors r+ |
bors
commented
Nov 14, 2020
Collaborator
📌 Commit b825ae7 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2020
Rollup of 15 pull requests Successful merges: - rust-lang#78352 (Do not call `unwrap` with `signatures` option enabled) - rust-lang#78590 (refactor: removing alloc::collections::vec_deque ignore-tidy-filelength) - rust-lang#78848 (Bump minimal supported LLVM version to 9) - rust-lang#78856 (Explicitly checking for or-pattern before test) - rust-lang#78948 (test: add `()=()=()=...` to weird-exprs.rs) - rust-lang#78962 (Add a test for r# identifiers) - rust-lang#78963 (Added some unit tests as requested) - rust-lang#78966 (Never inline C variadics, cold functions, functions with incompatible attributes ...) - rust-lang#78968 (Include llvm-as in llvm-tools-preview component) - rust-lang#78969 (Normalize function type during validation) - rust-lang#78980 (Fix rustc_ast_pretty print_qpath resulting in invalid macro input) - rust-lang#78986 (Avoid installing external LLVM dylibs) - rust-lang#78988 (Fix an intrinsic invocation on threaded wasm) - rust-lang#78993 (rustc_target: Fix dash vs underscore mismatches in option names) - rust-lang#79013 (Clean up outdated `use_once_payload` pretty printer comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#72680
cc #54883
r? @varkor