Uh oh!
There was an error while loading. Please reload this page.
Fix displaying errors when rustbook tests fail. - #79064
Merged
Merged
Conversation
rust-highfive
commented
Nov 15, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Nov 15, 2020
Member
Seems unfortunate these are only displayed via env logger, but @bors r+ p=1 |
bors
commented
Nov 15, 2020
Collaborator
📌 Commit 5b9e9d0 has been approved by |
ehuss
commented
Nov 15, 2020
ContributorAuthor
Oh, thinking about it more, I think it was changed by rust-lang/mdBook#1313. I didn't really think about the interactions here. |
Mark-Simulacrum
commented
Nov 15, 2020
Member
Looks like something should be changed. |
bors
commented
Nov 15, 2020
Collaborator
⌛ Testing commit 5b9e9d0 with merge d38281f2effdb6c05659864070df1312dea51763... |
bors
commented
Nov 15, 2020
Collaborator
💔 Test failed - checks-actions |
ehuss
commented
Nov 15, 2020
ContributorAuthor
bors
commented
Nov 15, 2020
Collaborator
bors
commented
Nov 15, 2020
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that output from mdbook is displayed when running the rustbook wrapper. I believe this was a regression as a result of #69115 where it was changed from running
rustdocdirectly to using rustbook.