Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #79138
Merged
Merged
Conversation
This is helpful when looking for CGUs where the size estimate isn't a good indicator of compilation time. I verified that moving the profiling timer call doesn't affect the results.
This is mostly me learning the codebase, so feel free to close the PR. It does have the small benefit that we statically know rustdoc isn't generating useless `span`s, though.
It's the same as clean::Function.
Replace it instead with `(clean::Function, Option<hir::Defaultness>)`.
It was exactly the same as `is_auto`.
… the color escape characters
…r-output-color, r=jyn514 Rustdoc test compiler output color Fixesrust-lang#72915 We just need to be sure it doesn't break rustdoc doctests' compilation checks. Maybe some other unforeseen consequences too? r? `@ehuss` cc `@rust-lang/rustdoc`
… r=Mark-Simulacrum [self-profiling] Include the estimated size of each cgu in the profile This is helpful when looking for CGUs where the size estimate isn't a good indicator of compilation time. I verified that moving the profiling timer call doesn't affect the results. Results: <img width="297" alt="Screen Shot 2020-11-03 at 7 25 04 AM" src="https://user-images.githubusercontent.com/831192/97985503-5901d100-1da6-11eb-9f10-f3e399702952.png"> `measureme` doesn't have support for custom arg names yet so `arg0` is the CGU name and `arg1` is the estimated size.
Get rid of `highlight::Class::None` This is mostly me learning the codebase for rust-lang#77939, so feel free to close the PR. It does have the small benefit that we statically know rustdoc isn't generating useless `span`s, though. r? `@GuillaumeGomez` cc `@matklad`
Fix exhaustiveness in case a byte string literal is used at slice type fixesrust-lang#79048
…ark-Simulacrum update rustfmt to v1.4.27 Fixesrust-lang/rustfmt#4528
Get rid of clean::{Method, TyMethod}
They're redundant and almost the same as `clean::Function`.
I needed this for rust-lang#78082, although I forget why.
r? `@GuillaumeGomez`Remove duplicate `Trait::auto` field It was exactly the same as `is_auto`. I found this while working on rust-lang#78082, but it's not required for that PR. r? `@GuillaumeGomez`
extend macro braces test r? `@varkor`
m-ou-se
commented
Nov 17, 2020
MemberAuthor
@bors r+ p=8 rollup=never |
bors
commented
Nov 17, 2020
Collaborator
📌 Commit f698505 has been approved by |
bors
commented
Nov 17, 2020
Collaborator
bors
commented
Nov 17, 2020
Collaborator
☀️ Test successful - checks-actions |
This was referenced Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
highlight::Class::None#79069 (Get rid ofhighlight::Class::None)clean::{Method, TyMethod}#79125 (Get rid of clean::{Method, TyMethod})Trait::autofield #79126 (Remove duplicateTrait::autofield)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup