Skip to content

Permit standalone generic parameters as const generic arguments in macros - #79164

Merged
bors merged 2 commits into
rust-lang:masterfrom
varkor:unbraced-single-segment-const-arguments
Nov 19, 2020
Merged

Permit standalone generic parameters as const generic arguments in macros#79164
bors merged 2 commits into
rust-lang:masterfrom
varkor:unbraced-single-segment-const-arguments

Conversation

@varkor

Copy link
Copy Markdown
Contributor

@varkorvarkor added A-const-generics Area: const generics (parameters and arguments) F-const_generics `#![feature(const_generics)]` F-min_const_generics labels Nov 18, 2020
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2020
@varkor
varkorforce-pushed the unbraced-single-segment-const-arguments branch from c63aa1c to 85bc953CompareNovember 18, 2020 13:17
@jyn514jyn514 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) labels Nov 18, 2020
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 85bc953 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 19, 2020
…t-arguments, r=petrochenkov
Permit standalone generic parameters as const generic arguments in macros
Fixesrust-lang#79127.
r? `@petrochenkov`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 19, 2020
…t-arguments, r=petrochenkov
Permit standalone generic parameters as const generic arguments in macros
Fixesrust-lang#79127.
r? ``@petrochenkov``
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2020
Rollup of 14 pull requests
Successful merges:
- rust-lang#78961 (Make bad "rust-call" arguments no longer ICE)
- rust-lang#79082 (Improve the diagnostic for when an `fn` contains qualifiers inside an `extern` block.)
- rust-lang#79090 (libary: Forward compiler-builtins "asm" and "mangled-names" feature)
- rust-lang#79094 (Add //ignore-macos to pretty-std-collections.rs)
- rust-lang#79101 (Don't special case constant operands when lowering intrinsics)
- rust-lang#79102 (Add two regression tests)
- rust-lang#79110 (Remove redundant notes in E0275)
- rust-lang#79116 (compiletest: Fix a warning in debuginfo tests on windows-gnu)
- rust-lang#79117 (add optimization fuel checks to some mir passes)
- rust-lang#79147 (Highlight MIR as Rust on GitHub)
- rust-lang#79149 (Move capture lowering from THIR to MIR)
- rust-lang#79155 (fix handling the default config for profiler and sanitizers)
- rust-lang#79156 (Allow using `download-ci-llvm` from directories other than the root)
- rust-lang#79164 (Permit standalone generic parameters as const generic arguments in macros)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b5fffdc into rust-lang:masterNov 19, 2020
@rustbotrustbot added this to the 1.50.0 milestone Nov 19, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-const-genericsArea: const generics (parameters and arguments)A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)F-const_generics`#![feature(const_generics)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot use const params from macros as const args without braces

6 participants

@varkor@petrochenkov@bors@rust-highfive@jyn514@rustbot