Skip to content

Remove const_fn_feature_flags test - #79227

Merged
bors merged 1 commit into
rust-lang:masterfrom
sasurau4:test/move-cell-test-to-lib-core
Dec 1, 2020
Merged

Remove const_fn_feature_flags test#79227
bors merged 1 commit into
rust-lang:masterfrom
sasurau4:test/move-cell-test-to-lib-core

Conversation

@sasurau4

@sasurau4sasurau4 commented Nov 20, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

Helps with #76268

I found const_fn_feature_flags is targeting feature-gate and remove it.

r? @matklad

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2020
@m-ou-se

m-ou-se commented Nov 21, 2020

Copy link
Copy Markdown
Member

These are tests to check how the compiler handles constants, not really tests for Cell. So maybe tests/cell.rs isn't the right location for them.

@sasurau4

sasurau4 commented Nov 24, 2020

Copy link
Copy Markdown
ContributorAuthor

@m-ou-se
I see. According to rustc_dev_guide, should these tests be simply removed?

Also, remove those strings from any tests. If there are tests specifically targeting the feature-gate (i.e., testing that the feature-gate is required to use the feature, but nothing else), simply remove the test.

@matklad

matklad commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

Uhu, I also think that we should leave const_let_promote in places as an ui tests, and that we should just remove const_fn_feature_flags one

@sasurau4
sasurau4force-pushed the test/move-cell-test-to-lib-core branch from b7605f9 to 5e1cbfaCompareNovember 26, 2020 12:14
@sasurau4sasurau4 changed the title Move cell test to in library/coreRemove const-fn-feature-flags testNov 26, 2020
@sasurau4sasurau4 changed the title Remove const-fn-feature-flags testRemove const_fn_feature_flags testNov 26, 2020
@jyn514jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Nov 29, 2020
@jyn514

jyn514 commented Nov 29, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 29, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5e1cbfa has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 30, 2020
@Dylan-DPC
Rollup merge ofrust-lang#79227- sasurau4:test/move-cell-test-to-lib…
0d49461
…-core, r=jyn514
Remove const_fn_feature_flags test
## Overview
Helps with rust-lang#76268
I found `const_fn_feature_flags` is targeting feature-gate and remove it.
r? `@matklad`
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Nov 30, 2020
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Dec 1, 2020
@m-ou-se
Rollup merge ofrust-lang#79227- sasurau4:test/move-cell-test-to-lib…
2fffcce
…-core, r=jyn514
Remove const_fn_feature_flags test
## Overview
Helps with rust-lang#76268
I found `const_fn_feature_flags` is targeting feature-gate and remove it.
r? `@matklad`
This was referenced Dec 1, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2020
@bors
Auto merge ofrust-lang#79596- m-ou-se:rollup-hujx3c7, r=m-ou-se
b2dd829
Rollup of 11 pull requests
Successful merges:
- rust-lang#79038 (Change ui test that are run-pass and that do not test the compiler to library tests)
- rust-lang#79184 (Stop adding '*' at the end of slice and str typenames for MSVC case)
- rust-lang#79227 (Remove const_fn_feature_flags test)
- rust-lang#79444 (Move const ip in ui test to unit test)
- rust-lang#79522 (Validate lint docs separately.)
- rust-lang#79525 (Add -Z normalize-docs and enable it for compiler docs)
- rust-lang#79527 (Move intra-doc link tests into a subdirectory)
- rust-lang#79548 (Show since when a function is const in stdlib)
- rust-lang#79568 (update Miri)
- rust-lang#79573 (Update with status for various NetBSD ports.)
- rust-lang#79583 (Update books)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bf3f4c8 into rust-lang:masterDec 1, 2020
@rustbotrustbot added this to the 1.50.0 milestone Dec 1, 2020
@sasurau4
sasurau4 deleted the test/move-cell-test-to-lib-core branch December 1, 2020 15:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@matkladmatklad

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

7 participants

@sasurau4@m-ou-se@matklad@jyn514@bors@rust-highfive@rustbot