Uh oh!
There was an error while loading. Please reload this page.
Eliminated SmallIntSet - #7934
Closed
sfackler wants to merge 1 commit into
Closed
Conversation
huonw
commented
Jul 20, 2013
Contributor
The reason that |
thestinger
commented
Jul 20, 2013
Contributor
I don't think these are really equivalent. If you add |
huonw
commented
Jul 21, 2013
Contributor
@thestinger |
thestinger
commented
Jul 21, 2013
Contributor
Ah. |
huonw
commented
Jul 21, 2013
Contributor
@sfackler needs a rebase. |
sfackler
commented
Jul 21, 2013
MemberAuthor
@huonw Done. |
SmallIntSet is equivalent to BitvSet but with 8 times the memory overhead. There's no reason for it to exist.
bors added a commit
that referenced
this pull request
Jul 23, 2013
SmallIntSet is equivalent to BitvSet but with 64 times the memory overhead. There's no reason for it to exist. SmallIntSet's overhead should really only be 8 times, but for some reason, `sys::size_of::<Option<()>>() == 8`, not 1.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 23, 2021
Fix ICE in undocumented_unsafe_blocks changelog: Fix ICE in [`undocumented_unsafe_blocks`] closes: rust-lang#7934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmallIntSet is equivalent to BitvSet but with 64 times the memory
overhead. There's no reason for it to exist.
SmallIntSet's overhead should really only be 8 times, but for some
reason,
sys::size_of::<Option<()>>() == 8, not 1.