Uh oh!
There was an error while loading. Please reload this page.
Stabilize all stable methods of Ipv4Addr, Ipv6Addr and IpAddr as const - #79342
Merged
Conversation
rust-highfive
commented
Nov 23, 2020
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
m-ou-se
commented
Nov 27, 2020
Member
cc @rust-lang/wg-const-eval |
m-ou-se
reviewed
Nov 27, 2020
Uh oh!
There was an error while loading. Please reload this page.
sfackler
commented
Nov 27, 2020
Member
@rfcbot fcp merge |
Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
…s const `Ipv4Addr` - `octets` - `is_loopback` - `is_private` - `is_link_local` - `is_multicast` - `is_broadcast` - `is_docmentation` - `to_ipv6_compatible` - `to_ipv6_mapped` `Ipv6Addr` - `segments` - `is_unspecified` - `is_loopback` - `is_multicast` - `to_ipv4` `IpAddr` - `is_unspecified` - `is_loopback` - `is_multicast`
rfcbot
commented
Dec 9, 2020
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
commented
Dec 19, 2020
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
oli-obk
commented
Dec 19, 2020
Contributor
@bors r+ |
bors
commented
Dec 19, 2020
Collaborator
📌 Commit 4fcef4b has been approved by |
bors
commented
Dec 19, 2020
Collaborator
bors
commented
Dec 19, 2020
Collaborator
☀️ Test successful - checks-actions |
34 tasks
CDirkx added a commit
to CDirkx/rust
that referenced
this pull request
Feb 15, 2021
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 21, 2021
Update RELEASES.md 1.50 to include methods stabilized in rust-lang#79342 I noticed that rust-lang#79342 was missing from the release notes for 1.50.
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 21, 2021
Update RELEASES.md 1.50 to include methods stabilized in rust-lang#79342 I noticed that rust-lang#79342 was missing from the release notes for 1.50.
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 21, 2021
Update RELEASES.md 1.50 to include methods stabilized in rust-lang#79342 I noticed that rust-lang#79342 was missing from the release notes for 1.50.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#81300 (BTree: share panicky test code & test panic during clear, clone) - rust-lang#81706 (Document BinaryHeap unsafe functions) - rust-lang#81833 (parallelize x.py test tidy) - rust-lang#81966 (Add new `rustc` target for Arm64 machines that can target the iphonesimulator) - rust-lang#82154 (Update RELEASES.md 1.50 to include methods stabilized in rust-lang#79342) - rust-lang#82177 (Do not delete bootstrap.exe on Windows during clean) - rust-lang#82181 (Add check for ES5 in CI) - rust-lang#82229 (Add [A-diagnostics] bug report template) - rust-lang#82233 (try-back-block-type test: Use TryFromSliceError for From test) - rust-lang#82302 (Remove unsafe impl Send for CompletedTest & TestResult) - rust-lang#82349 (test: Print test name only once on timeout) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes all currently stable methods of
Ipv4Addr,Ipv6AddrandIpAddras const.Tracking issue: #76205
Ipv4Addr(const_ipv4):octetsis_loopbackis_privateis_link_localis_multicastis_broadcastis_docmentationto_ipv6_compatibleto_ipv6_mappedIpv6Addr(const_ipv6):segmentsis_unspecifiedis_loopbackis_multicastto_ipv4IpAddr(const_ip):is_unspecifiedis_loopbackis_multicastMotivation
The ip methods seem like prime candidates to be made const: their behavior is defined by an external spec, and based solely on the byte contents of an address. These methods have been made unstable const in the beginning of September, after the necessary const integer arithmetic was stabilized.
There is currently a PR open (#78802) to change the internal representation of
IpAddr{4,6}fromlibctypes to a byte array. This does not have any impact on the constness of the methods.Implementation
Most of the stabilizations are straightforward, with the exception of
Ipv6Addr::segments, which uses the unstable featureconst_fn_transmute. The code could be rewritten to equivalent stable code, but this leads to worse code generation (#75085).This is why
segmentsgets marked with#[rustc_allow_const_fn_unstable(const_fn_transmute)], like the already const-stableIpv6Addr::new, the justification being that a const-stable alternative implementation exists #76206 (comment).Future posibilities
This PR const-stabilizes all currently stable ip methods, however there are also a number of unstable methods under the
ipfeature (#27709). These methods are already unstable const. There is a PR open (#76098) to stabilize those methods, which could include const-stabilization. However, stabilizing those methods as const is dependent onIpv4Addr::octetsandIpv6Addr::segments(covered by this PR).